All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ewan Milne <emilne@redhat.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
	jiangyiwen@huawei.com, snitzer@redhat.com
Subject: Re: [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled
Date: Thu, 04 Feb 2016 22:16:14 -0500	[thread overview]
Message-ID: <yq1zivfg83l.fsf@sermon.lab.mkp.net> (raw)
In-Reply-To: <1454603812.22112.246.camel@localhost.localdomain> (Ewan Milne's message of "Thu, 04 Feb 2016 11:36:52 -0500")

>>>>> "Ewan" == Ewan Milne <emilne@redhat.com> writes:

Ewan> Maybe it's unnecessary, but I would put parenthesis around (ret ==
Ewan> ... -EIO); for clarity.

Sure.

Ewan> I would prefer that additional enum/constant values be added to
Ewan> the end of the series, here you are changing the ordinal value of
Ewan> BLKPREP_DEFER from 2 to 3.  Could you swap these?

I felt that KILL and INVALID were closely related. That's why I kept
them together. But it doesn't matter to me.

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2016-02-05  3:16 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-04  2:08 [dm-devel] [PATCH] dm-mpath: fix a tiny case which can cause an infinite loop jiangyiwen
2016-02-04  3:24 ` Mike Snitzer
2016-02-04  3:49   ` jiangyiwen
2016-02-04  4:25     ` Mike Snitzer
2016-02-04  5:03       ` Martin K. Petersen
2016-02-04  6:48       ` [PATCH] block/sd: Return -EREMOTEIO when WRITE SAME and DISCARD are disabled Martin K. Petersen
2016-02-04  9:16         ` jiangyiwen
2016-02-05  3:13           ` Martin K. Petersen
2016-02-05  3:39             ` jiangyiwen
2016-02-16 12:14             ` jiangyiwen
2016-02-18  0:22               ` Martin K. Petersen
2016-02-04 14:14         ` Hannes Reinecke
2016-02-04 16:36         ` Ewan Milne
2016-02-05  3:16           ` Martin K. Petersen [this message]
2016-02-04  8:25       ` dm-mpath: fix a tiny case which can cause an infinite loop jiangyiwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq1zivfg83l.fsf@sermon.lab.mkp.net \
    --to=martin.petersen@oracle.com \
    --cc=emilne@redhat.com \
    --cc=jiangyiwen@huawei.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=snitzer@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.