On Fri, 24 Jun 2011 17:03:22 +0900, KOSAKI Motohiro wrote: > Now, i915_gem_inactive_shrink() should return -1 instead of 0 if it > can't take a lock. Otherwise, vmscan is getting a lot of confusing > because vmscan can't distinguish "can't take a lock temporary" and > "we've shrank all of i915 objects". This doesn't look like the cleanest change possible. I think it would be better if the shrink function could uniformly return an error indication so that we wouldn't need the weird looking conditional return. -- keith.packard@intel.com