Julian Margetson <runaway@candw.ms> writes:

> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>> Julian Margetson <runaway@candw.ms> writes:
>>
>>> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runaway@candw.ms> writes:
>>>>
>>>>> I have been running my machine mostly configured for pciex1  thus with
>>>>> the sata_dwc disabled.
>>>>> The changes to sata_dwc-460ex do cause an oops.
>>>>> I will try to give more detailed info over this weekend .
>>>> The driver as is upstream would do that since it unconditionally
>>>> dereferences a null pointer in the probe function.  My patch fixes that
>>>> as a side-effect.
>>>>
>>> patching file drivers/ata/Kconfig
>>>
>>> Hunk #1 FAILED at 296.
>> [...]
>>
>>> root@julian-VirtualBox:/usr/src/linux-3.18.25#
>> The patch is against 4.4-rc5.
>>
>  CC      drivers/ata/sata_dwc_460ex.o
>
> drivers/ata/sata_dwc_460ex.c:198:15: error: variable ‘sata_dwc_dma_dws’ has initializer but incomplete type
>
>  static struct dw_dma_slave sata_dwc_dma_dws = {
>                ^

It builds, albeit with an unrelated warning, using the attached config.
Maybe there's a missing config dependency somewhere.

-- 
Måns Rullgård