From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932317AbbJ0Mkw (ORCPT ); Tue, 27 Oct 2015 08:40:52 -0400 Received: from unicorn.mansr.com ([81.2.72.234]:53731 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932213AbbJ0Mku convert rfc822-to-8bit (ORCPT ); Tue, 27 Oct 2015 08:40:50 -0400 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Stephen Hemminger Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr Subject: Re: [PATCH v3 2/2] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller References: <1445895295-16778-1-git-send-email-mans@mansr.com> <1445895295-16778-2-git-send-email-mans@mansr.com> <20151027150209.043946d4@samsung9> Date: Tue, 27 Oct 2015 12:40:42 +0000 In-Reply-To: <20151027150209.043946d4@samsung9> (Stephen Hemminger's message of "Tue, 27 Oct 2015 15:02:09 +0900") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Hemminger writes: >> + .get_settings = nb8800_get_settings, >> + .set_settings = nb8800_set_settings, >> + .nway_reset = nb8800_nway_reset, >> + .get_link = ethtool_op_get_link, >> +}; >> + > > Since you are implementing ethtool please add a driver > info function. I don't know what I'd set there that the fallback code doesn't. -- Måns Rullgård mans@mansr.com