From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbbKJTZv (ORCPT ); Tue, 10 Nov 2015 14:25:51 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:42973 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750992AbbKJTZt convert rfc822-to-8bit (ORCPT ); Tue, 10 Nov 2015 14:25:49 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller References: <1447172063-27234-1-git-send-email-mans@mansr.com> <564241BF.4020700@free.fr> Date: Tue, 10 Nov 2015 19:25:40 +0000 In-Reply-To: <564241BF.4020700@free.fr> (Mason's message of "Tue, 10 Nov 2015 20:13:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mason writes: > On 10/11/2015 17:14, Mans Rullgard wrote: > >> This adds a driver for the Aurora VLSI NB8800 Ethernet controller. >> It is an almost complete rewrite of a driver originally found in >> a Sigma Designs 2.6.22 tree. >> >> Signed-off-by: Mans Rullgard >> --- >> Changes: >> - Refactored mdio access functions >> - Refactored register access helpers >> - Improved error handling in rx buffer allocation >> - Optimised some fifo parameters >> - Overhauled tx dma. Multiple packets are now chained in a single dma >> operation if xmit_more is set, improving performance. >> - Improved rx irq handling. It's not possible to disable interrupts >> entirely for napi poll, but they can be slowed down a little. >> - Use readx_poll_timeout in various places >> - Improved error detection >> - Improved statistics >> - Report hardware statistics counters through ethtool >> - Improved tangox-specific setup >> - Support for flow control using pause frames >> - Explanatory comments added >> - Various minor stylistic changes >> --- >> drivers/net/ethernet/Kconfig | 1 + >> drivers/net/ethernet/Makefile | 1 + >> drivers/net/ethernet/aurora/Kconfig | 20 + >> drivers/net/ethernet/aurora/Makefile | 1 + >> drivers/net/ethernet/aurora/nb8800.c | 1530 ++++++++++++++++++++++++++++++++++ >> drivers/net/ethernet/aurora/nb8800.h | 314 +++++++ >> 6 files changed, 1867 insertions(+) > > The code has grown much since the previous patch, despite some > refactoring. Is this mostly due to ethtool_ops support? > > drivers/net/ethernet/aurora/nb8800.c | 1146 ++++++++++++++++++++++++++++++++++ > drivers/net/ethernet/aurora/nb8800.h | 230 +++++++ Some of the increase is from new features, some from improvements, and then there are a bunch of new comments. -- Måns Rullgård mans@mansr.com