From: "Måns Rullgård" <mans@mansr.com>
To: "Chen.Yu" <chyyuu@gmail.com>
Cc: linux-kernel@vger.kernel.org, levex@linux.com,
xiaoqixue_1@163.com, fanwlexca@gmail.com
Subject: Re: [PATCH] scsi: integer overflow in megadev_ioctl()
Date: Fri, 13 Dec 2013 18:59:44 +0000 [thread overview]
Message-ID: <yw1xbo0kinkv.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <1386960092-32475-1-git-send-email-chyyuu@gmail.com> (Chen Yu's message of "Sat, 14 Dec 2013 02:41:32 +0800")
"Chen.Yu" <chyyuu@gmail.com> writes:
> From: "Chen.Yu" <chyyuu@gmail.com>
>
> There is a potential integer overflow in megadev_ioctl() if
> userspace passes in a large u32 variable uioc.adapno.
> The int variable adapno would < 0, leading to an error
> array access for hdb_soft_state[adapno], or an error
> copy_to_user(uioc.uioc_uaddr, mcontroller+adapno,..)
>
> Reported-by: Wenliang Fan <fanwlexca@gmail.com>
> Suggested-by: Qixue Xiao <xiaoqixue_1@163.com>
> Signed-off-by: Yu Chen <chyyuu@gmail.com>
> Reviewed-by: Levente Kurusa <levex@linux.com>
> ---
> drivers/scsi/megaraid.c | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c
> index 816db12..0b90c54 100644
> --- a/drivers/scsi/megaraid.c
> +++ b/drivers/scsi/megaraid.c
> @@ -3099,7 +3099,10 @@ megadev_ioctl(struct file *filep, unsigned int cmd, unsigned long arg)
> /*
> * Which adapter
> */
> - if( (adapno = GETADAP(uioc.adapno)) >= hba_count )
> + adapno = GETADAP(uioc.adapno);
> + if( adapno < 0 )
> + return (-EINVAL);
> + if( adapno >= hba_count )
> return (-ENODEV);
This relies on implementation-defined behaviour when converting an
unsigned integer to signed integer. A simpler and more robust fix is to
make the local variable 'adapno' unsigned.
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2013-12-13 18:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-13 18:41 [PATCH] scsi: integer overflow in megadev_ioctl() Chen.Yu
2013-12-13 18:59 ` Måns Rullgård [this message]
2013-12-14 0:35 ` Yu Chen
-- strict thread matches above, loose matches on Subject: below --
2013-12-14 0:51 Chen.Yu
2013-12-13 16:55 Yu Chen
2013-12-13 17:01 ` Levente Kurusa
2013-12-13 17:31 ` Yu Chen
2013-12-13 17:43 ` Levente Kurusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xbo0kinkv.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=chyyuu@gmail.com \
--cc=fanwlexca@gmail.com \
--cc=levex@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiaoqixue_1@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.