From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 022C2C43381 for ; Fri, 1 Mar 2019 14:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC80B20675 for ; Fri, 1 Mar 2019 14:52:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388626AbfCAOwr convert rfc822-to-8bit (ORCPT ); Fri, 1 Mar 2019 09:52:47 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:54588 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbfCAOwr (ORCPT ); Fri, 1 Mar 2019 09:52:47 -0500 Received: by unicorn.mansr.com (Postfix, from userid 51770) id 95D4115632; Fri, 1 Mar 2019 14:52:45 +0000 (GMT) From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Tony Lindgren Cc: Jeroen Hofstee , netdev@vger.kernel.org, Mugunthan V N , Grygorii Strashko , "open list\:TI ETHERNET SWITCH DRIVER \(CPSW\)" , open list Subject: Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517 References: <1477668756-2651-1-git-send-email-jhofstee@victronenergy.com> <20161028155213.2t3nwwe3lqaynaer@atomide.com> <20161028181914.mskebckucukzhxhz@atomide.com> Date: Fri, 01 Mar 2019 14:52:45 +0000 In-Reply-To: <20161028181914.mskebckucukzhxhz@atomide.com> (Tony Lindgren's message of "Fri, 28 Oct 2016 11:19:14 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tony Lindgren writes: > * Jeroen Hofstee [161028 11:19]: >> Hello Tony, >> >> On 28-10-16 17:52, Tony Lindgren wrote: >> > * Jeroen Hofstee [161028 08:33]: >> > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac >> > > id to common file") did not only move the code for an am3517, it also >> > > added the slave parameter, resulting in an invalid (all zero) mac address >> > > being returned for an am3517, since it only has a single emac and the slave >> > > parameter is pointing to the second. So simply always read the first and >> > > valid mac-address for a ti,am3517-emac. >> > And others davinci_emac.c users can have more than one. So is the >> > reason the slave parameter points to the second instance because >> > of the location in the hardware? >> >> Sort of, the slave parameter gets determined by the fact if there is one >> or two register range(s) associated with the davinci_emac. In davinci_emac.c >> >> res_ctrl = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> ... >> rc = davinci_emac_try_get_mac(pdev, res_ctrl ? 0 : 1, >> priv->mac_addr); >> >> So it there are two ranges, the slave param becomes 0. It there is only one, >> it >> will be 1. Since the am3517 only has a single regs entry it ends up with >> slave 1, >> while there is only a single davinci_emac. > > OK thanks for clarifying it: > > Acked-by: Tony Lindgren What happened to this patch? -- Måns Rullgård From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: [PATCH v2] net: cpsw: fix obtaining mac address for am3517 Date: Fri, 01 Mar 2019 14:52:45 +0000 Message-ID: References: <1477668756-2651-1-git-send-email-jhofstee@victronenergy.com> <20161028155213.2t3nwwe3lqaynaer@atomide.com> <20161028181914.mskebckucukzhxhz@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <20161028181914.mskebckucukzhxhz@atomide.com> (Tony Lindgren's message of "Fri, 28 Oct 2016 11:19:14 -0700") Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Jeroen Hofstee , netdev@vger.kernel.org, Mugunthan V N , Grygorii Strashko , "open list:TI ETHERNET SWITCH DRIVER (CPSW)" , open list List-Id: linux-omap@vger.kernel.org Tony Lindgren writes: > * Jeroen Hofstee [161028 11:19]: >> Hello Tony, >> >> On 28-10-16 17:52, Tony Lindgren wrote: >> > * Jeroen Hofstee [161028 08:33]: >> > > Commit b6745f6e4e63 ("drivers: net: cpsw: davinci_emac: move reading mac >> > > id to common file") did not only move the code for an am3517, it also >> > > added the slave parameter, resulting in an invalid (all zero) mac address >> > > being returned for an am3517, since it only has a single emac and the slave >> > > parameter is pointing to the second. So simply always read the first and >> > > valid mac-address for a ti,am3517-emac. >> > And others davinci_emac.c users can have more than one. So is the >> > reason the slave parameter points to the second instance because >> > of the location in the hardware? >> >> Sort of, the slave parameter gets determined by the fact if there is one >> or two register range(s) associated with the davinci_emac. In davinci_emac.c >> >> res_ctrl = platform_get_resource(pdev, IORESOURCE_MEM, 1); >> ... >> rc = davinci_emac_try_get_mac(pdev, res_ctrl ? 0 : 1, >> priv->mac_addr); >> >> So it there are two ranges, the slave param becomes 0. It there is only one, >> it >> will be 1. Since the am3517 only has a single regs entry it ends up with >> slave 1, >> while there is only a single davinci_emac. > > OK thanks for clarifying it: > > Acked-by: Tony Lindgren What happened to this patch? -- Måns Rullgård