From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Date: Fri, 22 Jan 2016 12:05:40 +0000 Message-ID: References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450724880.30729.250.camel@linux.intel.com> <1450731289.30729.282.camel@linux.intel.com> <1450781890.30729.298.camel@linux.intel.com> <1452159294.30729.405.camel@linux.intel.com> <1452243464.30729.430.camel@linux.intel.com> <1453317808.2521.135.camel@linux.intel.com> <1453457080.2521.179.camel@linux.intel.com> <1453463800.2521.189.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from unicorn.mansr.com ([81.2.72.234]:54245 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbcAVMFm (ORCPT ); Fri, 22 Jan 2016 07:05:42 -0500 In-Reply-To: <1453463800.2521.189.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 22 Jan 2016 13:56:40 +0200") Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Andy Shevchenko Cc: Andy Shevchenko , Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel@vger.kernel.org" Andy Shevchenko writes: > On Fri, 2016-01-22 at 11:13 +0000, M=C3=A5ns Rullg=C3=A5rd wrote: >> Andy Shevchenko writes: >> > On Wed, 2016-01-20 at 20:07 +0000, M=C3=A5ns Rullg=C3=A5rd wrote: >> > > Andy Shevchenko writes: > >> > In=C2=A0DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? >>=20 >> Is there a wrong indentation somewhere?=C2=A0=C2=A0I don't see it. > > My git diff shows this in particular: > > --- a/drivers/dma/dw/core.c > +++ b/drivers/dma/dw/core.c > @@ -45,10 +45,10 @@ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0DW_DMA_MSIZE_16;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0\ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0u8 _dmsize =3D _is_slave ? _sconfig->dst_max= burst :=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0\ > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0DW_DMA_MSIZE_16;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0\ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0u8 _dms =3D (_is_slave && _dwc->direction =3D=3D D= MA_MEM_TO_DEV) ? \ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_d= wc->p_master : _dwc->m_master;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0\ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0u8 _sms =3D (_is_slave && _dwc->direction =3D=3D D= MA_DEV_TO_MEM) ? \ > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0_d= wc->p_master : _dwc->m_master;=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0\ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0u8 _dms =3D (_is_slave && _dwc->direction =3D=3D D= MA_MEM_TO_DEV) ?=C2=A0=C2=A0=C2=A0=C2=A0\ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0_dwc->p_master : _dwc->m_master;=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0\ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0u8 _sms =3D (_is_slave && _dwc->direction =3D=3D D= MA_DEV_TO_MEM) ?=C2=A0=C2=A0=C2=A0=C2=A0\ > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0_dwc->p_master : _dwc->m_master;=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0\ > > Means in your case the ' \' is used, in mine =E2=80=94 '\t\' at the e= nd of > lines. Oh, I see it now. Two lines have a space rather than a tab since a tab would push them over 80 columns. Now those lines could be shortened by simply dropping the "_is_slave" since this is necessarily true if the other half of the && is. >> Now the question: who do you prefer to submit the series (dw_dmac)? >> > Me >> > or you? >> >=20 >> > In case you would like to do it (what I see in your dwc-sata branc= h >> > today): >> > Acked-by: Andy Shevchenko >>=20 >> I'll fix the above, give your changes a review, and add my sign-off >> before sending the series, today or during the weekend. > > OK. > > Just to be sure we are on the same page. I assume your dwc-sata branc= h > as for submitting. Yes, I'm not aware of anything that needs to change in that branch. --=20 M=C3=A5ns Rullg=C3=A5rd From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753392AbcAVMFw (ORCPT ); Fri, 22 Jan 2016 07:05:52 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:54245 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753190AbcAVMFm (ORCPT ); Fri, 22 Jan 2016 07:05:42 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Andy Shevchenko Cc: Andy Shevchenko , Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450724880.30729.250.camel@linux.intel.com> <1450731289.30729.282.camel@linux.intel.com> <1450781890.30729.298.camel@linux.intel.com> <1452159294.30729.405.camel@linux.intel.com> <1452243464.30729.430.camel@linux.intel.com> <1453317808.2521.135.camel@linux.intel.com> <1453457080.2521.179.camel@linux.intel.com> <1453463800.2521.189.camel@linux.intel.com> Date: Fri, 22 Jan 2016 12:05:40 +0000 In-Reply-To: <1453463800.2521.189.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 22 Jan 2016 13:56:40 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Fri, 2016-01-22 at 11:13 +0000, Måns Rullgård wrote: >> Andy Shevchenko writes: >> > On Wed, 2016-01-20 at 20:07 +0000, Måns Rullgård wrote: >> > > Andy Shevchenko writes: > >> > In DWC_DEFAULT_CTLLO() can we do tab indentation for \ ? >> >> Is there a wrong indentation somewhere?  I don't see it. > > My git diff shows this in particular: > > --- a/drivers/dma/dw/core.c > +++ b/drivers/dma/dw/core.c > @@ -45,10 +45,10 @@ >                         DW_DMA_MSIZE_16;                        \ >                 u8 _dmsize = _is_slave ? _sconfig->dst_maxburst :       \ >                         DW_DMA_MSIZE_16;                        \ > -               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ? \ > -                       _dwc->p_master : _dwc->m_master;                \ > -               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ? \ > -                       _dwc->p_master : _dwc->m_master;                \ > +               u8 _dms = (_is_slave && _dwc->direction == DMA_MEM_TO_DEV) ?    \ > +                          _dwc->p_master : _dwc->m_master;                     \ > +               u8 _sms = (_is_slave && _dwc->direction == DMA_DEV_TO_MEM) ?    \ > +                          _dwc->p_master : _dwc->m_master;                     \ > > Means in your case the ' \' is used, in mine — '\t\' at the end of > lines. Oh, I see it now. Two lines have a space rather than a tab since a tab would push them over 80 columns. Now those lines could be shortened by simply dropping the "_is_slave" since this is necessarily true if the other half of the && is. >> Now the question: who do you prefer to submit the series (dw_dmac)? >> > Me >> > or you? >> > >> > In case you would like to do it (what I see in your dwc-sata branch >> > today): >> > Acked-by: Andy Shevchenko >> >> I'll fix the above, give your changes a review, and add my sign-off >> before sending the series, today or during the weekend. > > OK. > > Just to be sure we are on the same page. I assume your dwc-sata branch > as for submitting. Yes, I'm not aware of anything that needs to change in that branch. -- Måns Rullgård