From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752191AbbKKNyy (ORCPT ); Wed, 11 Nov 2015 08:54:54 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:44272 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751386AbbKKNyx convert rfc822-to-8bit (ORCPT ); Wed, 11 Nov 2015 08:54:53 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Mason Cc: Eric Dumazet , David Miller , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller References: <20151110.150403.1195107307226924000.davem@davemloft.net> <20151110.160615.1511568572619688788.davem@davemloft.net> <1447192280.17135.83.camel@edumazet-glaptop2.roam.corp.google.com> <56434584.2090802@free.fr> Date: Wed, 11 Nov 2015 13:54:52 +0000 In-Reply-To: <56434584.2090802@free.fr> (Mason's message of "Wed, 11 Nov 2015 14:41:24 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mason writes: > On 10/11/2015 22:51, Eric Dumazet wrote: > >> On Tue, 2015-11-10 at 21:21 +0000, Måns Rullgård wrote: >> >>> Even ixgbe uses napi_complete() while netdevice.h says one should >>> "consider using napi_complete_done() instead." Did the author consider >>> it and decide not to, or has the driver simply not been updated? >> >> napi_complete_done() is quite new, very few drivers use it. > > I was hoping to back-port this driver for my platform. Are the recent > features used in the driver available in 4.1? What about 3.14? xmit_more was added in 3.18, napi_complete_done() in 3.19. -- Måns Rullgård mans@mansr.com