All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Isely <isely@isely.net>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Dave Airlied <airlied@linux.ie>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915/lvds: Use i915.lvds_fixed_mode= as a last resort
Date: Wed, 20 Apr 2011 15:09:27 -0500 (CDT)	[thread overview]
Message-ID: <alpine.DEB.1.10.1104201458440.31843@cnc.isely.net> (raw)
In-Reply-To: <b7da2f$r640mo@fmsmga001.fm.intel.com>

On Wed, 20 Apr 2011, Chris Wilson wrote:

> On Wed, 20 Apr 2011 14:48:36 -0500 (CDT), Mike Isely <isely@isely.net> wrote:
> > 
> > Chris:
> > 
> > I've tested this patch and it doesn't help us here.  Even if I add 
> > lvds_fixed_mode=<whatever>, the display still comes up with the messed 
> > up configuration from the motherboard's completely ignorant BIOS.  It 
> > appears that lvds_fixed_mode is being ignored by the driver.
> 
> You can test the functionality of the patch by parsing
> i915.lvds_fixed_mode first rather than last.

I will test for that - it was the next thing I was going to dig into.


> 
> Then I just have to weigh up the wishes of Dave who has hordes of users
> desperate to fry their hardware, versus the tiny number who truly need
> an override and know what they are doing...

I understand your sentiment here.  But please also consider that this 
same feature existed on the UMS side for 3 years and I don't remember 
hearing about any flood of fried hardware because of it...

And really, this should be all about making legitimate capabilities 
available, not deliberately blocking them.

A good compromise, if this is really viewed as a legitimate problem 
(which I don't think it should be), would be to add an "I know what I'm 
doing, darnit" switch to the driver which would enable potentially 
hazardous tweaks.  Then one can hang all the "here there be dragons", 
"do not enter", "don't blame me for frying your hardware", etc caveats 
and warnings onto that switch...

  -Mike


-- 

Mike Isely
isely @ isely (dot) net
PGP: 03 54 43 4D 75 E5 CC 92 71 16 01 E2 B5 F5 C1 E8

  reply	other threads:[~2011-04-20 20:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-17  6:43 [PATCH 1/2] drm: Export the command-line mode parser Chris Wilson
2011-04-17  6:43 ` [PATCH 2/2] drm/i915/lvds: Use i915.lvds_fixed_mode= as a last resort Chris Wilson
2011-04-18 16:46   ` Mike Isely
2011-04-18 17:46     ` Mike Isely
2011-04-20 19:48   ` Mike Isely
2011-04-20 19:56     ` Chris Wilson
2011-04-20 20:09       ` Mike Isely [this message]
2011-04-21 22:30         ` Mike Isely
2011-04-21 22:37           ` Chris Wilson
2011-04-21 22:46             ` Mike Isely
2011-05-04 22:14               ` Mike Isely
2011-05-04 22:18                 ` [PATCH] drm/i915: Fix unset margins flag in drm_mode_parse_command_line_for_connector Mike Isely
2011-05-05  2:40                   ` Robert Lowery

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.1.10.1104201458440.31843@cnc.isely.net \
    --to=isely@isely.net \
    --cc=airlied@linux.ie \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.