From: Paul Walmsley <paul@pwsan.com>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Rajendra Nayak <rnayak@ti.com>,
Kalle Jokiniemi <kalle.jokiniemi@digia.com>,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP3: PM: Fix the pwrdm_enable/disable_hdwr_sar funcs
Date: Fri, 5 Jun 2009 16:44:37 -0600 (MDT) [thread overview]
Message-ID: <alpine.DEB.2.00.0906051642370.6425@utopia.booyaka.com> (raw)
In-Reply-To: <87hbyu72n8.fsf@deeprootsystems.com>
On Fri, 5 Jun 2009, Kevin Hilman wrote:
> Rajendra Nayak <rnayak@ti.com> writes:
>
> > The pwrdm_enable_hdwr_sar/pwrdm_disable_hdwr_sar do not
> > actually set/reset the SAVEANDRESTORE bit in the PWSTCTRL
> > register but modify some other bit instead.
> > This happens due to the OMAP3430ES2_SAVEANDRESTORE_SHIFT
> > being defined as (1 << 4) instead of just 4.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@ti.com>
>
> Thanks, pushing to PM branch.
>
> I'll wait to hear from Kalle if we can revert his previous patch
> for this.
I think Kalle covered this one already:
http://patchwork.kernel.org/patch/15586/
- Paul
>
> Kevin
>
> > ---
> > arch/arm/mach-omap2/prm-regbits-34xx.h | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/prm-regbits-34xx.h b/arch/arm/mach-omap2/prm-regbits-34xx.h
> > index 06fee29..d4ea370 100644
> > --- a/arch/arm/mach-omap2/prm-regbits-34xx.h
> > +++ b/arch/arm/mach-omap2/prm-regbits-34xx.h
> > @@ -411,7 +411,7 @@
> > /* PM_PREPWSTST_CAM specific bits */
> >
> > /* PM_PWSTCTRL_USBHOST specific bits */
> > -#define OMAP3430ES2_SAVEANDRESTORE_SHIFT (1 << 4)
> > +#define OMAP3430ES2_SAVEANDRESTORE_SHIFT 4
> >
> > /* RM_RSTST_PER specific bits */
> >
> > --
> > 1.5.4.7
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2009-06-05 22:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-05 13:00 [PATCH] OMAP3: PM: Fix the pwrdm_enable/disable_hdwr_sar funcs Rajendra Nayak
2009-06-05 22:10 ` Kevin Hilman
2009-06-05 22:44 ` Paul Walmsley [this message]
2009-06-05 22:53 ` Kevin Hilman
2009-06-08 7:57 ` VS: " Jokiniemi Kalle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.0906051642370.6425@utopia.booyaka.com \
--to=paul@pwsan.com \
--cc=kalle.jokiniemi@digia.com \
--cc=khilman@deeprootsystems.com \
--cc=linux-omap@vger.kernel.org \
--cc=rnayak@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.