From: Sage Weil <sage@inktank.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
ceph-devel@vger.kernel.org
Subject: Re: [PATCH -next] ceph: fix printk format warnings in file.c
Date: Fri, 19 Apr 2013 15:01:21 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.00.1304191501160.13036@cobra.newdream.net> (raw)
In-Reply-To: <5171B507.4030808@infradead.org>
Applied, thanks!
sage
On Fri, 19 Apr 2013, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix printk format warnings by using %zd for 'ssize_t' variables:
>
> fs/ceph/file.c:751:2: warning: format '%ld' expects argument of type 'long int', but argument 11 has type 'ssize_t' [-Wformat]
> fs/ceph/file.c:762:2: warning: format '%ld' expects argument of type 'long int', but argument 11 has type 'ssize_t' [-Wformat]
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Sage Weil <sage@inktank.com>
> Cc: ceph-devel@vger.kernel.org
> ---
> fs/ceph/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- linux-next-20130419.orig/fs/ceph/file.c
> +++ linux-next-20130419/fs/ceph/file.c
> @@ -748,7 +748,7 @@ retry_snap:
> goto out;
> }
>
> - dout("aio_write %p %llx.%llx %llu~%ld getting caps. i_size %llu\n",
> + dout("aio_write %p %llx.%llx %llu~%zd getting caps. i_size %llu\n",
> inode, ceph_vinop(inode), pos, count, inode->i_size);
> if (fi->fmode & CEPH_FILE_MODE_LAZY)
> want = CEPH_CAP_FILE_BUFFER | CEPH_CAP_FILE_LAZYIO;
> @@ -759,7 +759,7 @@ retry_snap:
> if (err < 0)
> goto out;
>
> - dout("aio_write %p %llx.%llx %llu~%ld got cap refs on %s\n",
> + dout("aio_write %p %llx.%llx %llu~%zd got cap refs on %s\n",
> inode, ceph_vinop(inode), pos, count, ceph_cap_string(got));
>
> if ((got & (CEPH_CAP_FILE_BUFFER|CEPH_CAP_FILE_LAZYIO)) == 0 ||
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
prev parent reply other threads:[~2013-04-19 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 8:19 linux-next: Tree for Apr 19 Stephen Rothwell
2013-04-19 8:19 ` Stephen Rothwell
2013-04-19 21:19 ` [PATCH -next] nilfs2: fix printk format warning in page.c Randy Dunlap
2013-04-19 21:20 ` [PATCH -next] ceph: fix printk format warnings in file.c Randy Dunlap
2013-04-19 22:01 ` Sage Weil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.00.1304191501160.13036@cobra.newdream.net \
--to=sage@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.