Re: [PATCH] cleancache: constify cleancache_ops structure

From: Julia Lawall <julia.lawall@lip6.fr>
To: David Vrabel <david.vrabel@citrix.com>
Cc: linux-mm@kvack.org, Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH] cleancache: constify cleancache_ops structure
Date: Thu, 21 Jan 2016 12:06:26 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.10.1601211205540.2530__15412.6790039756$1453374501$gmane$org@hadrien> (raw)
In-Reply-To: <56A0B6E7.9040201@citrix.com>

On Thu, 21 Jan 2016, David Vrabel wrote:

> On 23/12/15 21:06, Julia Lawall wrote:
> > The cleancache_ops structure is never modified, so declare it as const.
> >
> > This also removes the __read_mostly declaration on the cleancache_ops
> > variable declaration, since it seems redundant with const.
> >
> > Done with the help of Coccinelle.
> >
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> >
> > ---
> >
> > Not sure that the __read_mostly change is correct.  Does it apply to the
> > variable, or to what the variable points to?
>
> The variable, so...

Thanks.  I'll update the patch, unless you have already fixed it.

julia

> > --- a/mm/cleancache.c
> > +++ b/mm/cleancache.c
> > @@ -22,7 +22,7 @@
> >   * cleancache_ops is set by cleancache_register_ops to contain the pointers
> >   * to the cleancache "backend" implementation functions.
> >   */
> > -static struct cleancache_ops *cleancache_ops __read_mostly;
> > +static const struct cleancache_ops *cleancache_ops;
>
> ...you want to retain the __read_mostly here.
>
> David
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>