Re: [PATCH v2 11/18] xen/pvcalls: implement accept command

From: Stefano Stabellini <sstabellini@kernel.org>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: jgross@suse.com, Stefano Stabellini <stefano@aporeto.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	linux-kernel@vger.kernel.org, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 11/18] xen/pvcalls: implement accept command
Date: Fri, 2 Jun 2017 12:19:41 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.10.1706021219340.18759__15530.9090660468$1496431280$gmane$org@sstabellini-ThinkPad-X260> (raw)
In-Reply-To: <bb6fe01c-018c-811b-f728-2abef74cfb75@oracle.com>

On Fri, 26 May 2017, Boris Ostrovsky wrote:
> >  static void __pvcalls_back_accept(struct work_struct *work)
> >  {
> > +	struct sockpass_mapping *mappass = container_of(
> > +		work, struct sockpass_mapping, register_work);
> > +	struct sock_mapping *map;
> > +	struct pvcalls_ioworker *iow;
> > +	struct pvcalls_back_priv *priv;
> > +	struct xen_pvcalls_response *rsp;
> > +	struct xen_pvcalls_request *req;
> > +	void *page = NULL;
> > +	int notify;
> > +	int ret = -EINVAL;
> > +	unsigned long flags;
> > +
> > +	priv = mappass->priv;
> > +	/* We only need to check the value of "cmd" atomically on read. */
> > +	spin_lock_irqsave(&mappass->copy_lock, flags);
> > +	req = &mappass->reqcopy;
> > +	if (req->cmd != PVCALLS_ACCEPT) {
> > +		spin_unlock_irqrestore(&mappass->copy_lock, flags);
> > +		return;
> > +	}
> > +	spin_unlock_irqrestore(&mappass->copy_lock, flags);
> > +
> > +	map = kzalloc(sizeof(*map), GFP_KERNEL);
> 
> >From here on, the code looks almost identical to connect. Can this be
> factored out?

Yes, good idea, I'll do that

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel