Re: [patch] mm, oom: fix unnecessary killing of additional processes

From: David Rientjes <rientjes@google.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [patch] mm, oom: fix unnecessary killing of additional processes
Date: Fri, 22 Jun 2018 11:49:14 -0700 (PDT)	[thread overview]
Message-ID: <alpine.DEB.2.21.1806221147090.110785@chino.kir.corp.google.com> (raw)
In-Reply-To: <20180622142917.GB10465@dhcp22.suse.cz>

On Fri, 22 Jun 2018, Michal Hocko wrote:

> > > preempt_disable() is required because it calls kvm_kick_many_cpus() with 
> > > wait == true because KVM_REQ_APIC_PAGE_RELOAD sets KVM_REQUEST_WAIT and 
> > > thus the smp_call_function_many() is going to block until all cpus can run 
> > > ack_flush().
> > 
> > I will make sure to talk to the maintainer of the respective code to
> > do the nonblock case correctly.
> 
> I've just double checked this particular code and the wait path and this
> one is not a sleep. It is a busy wait for IPI to get handled. So this
> one should be OK AFAICS. Anyway I will send an RFC and involve
> respective maintainers to make sure I am not making any incorrect
> assumptions.

Do you believe that having the only potential source of memory freeing 
busy waiting for all other cpus on the system to run ack_flush() is 
particularly dangerous given the fact that they may be allocating 
themselves?