From: Thomas Gleixner <tglx@linutronix.de>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Radim Krcmar <rkrcmar@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juergen Gross <jgross@suse.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
steven.sistare@oracle.com, daniel.m.jordan@oracle.com,
x86@kernel.org, kvm@vger.kernel.org
Subject: Re: [patch 3/7] x86/kvmclock: Decrapify kvm_register_clock()
Date: Fri, 6 Jul 2018 19:39:25 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.21.1807061939120.1592@nanos.tec.linutronix.de> (raw)
In-Reply-To: <e3185855-6e63-a07e-629a-0d4afcf3ca6b@redhat.com>
On Fri, 6 Jul 2018, Paolo Bonzini wrote:
> Decrapification went a bit too far...
>
> On 06/07/2018 18:13, Thomas Gleixner wrote:
> > - int cpu = smp_processor_id();
> > - int low, high, ret;
> > struct pvclock_vcpu_time_info *src;
> > + int cpu = smp_processor_id();
> > + u64 pa;
> >
> > if (!hv_clock)
> > - return 0;
> > -
> > - src = &hv_clock[cpu].pvti;
>
> ... the line above should not have been a "-". That, or initialize it
> in the declaration. Whoever applies can fix it, no need to repost.
> I'll test with the above fix.
Indeed.
next prev parent reply other threads:[~2018-07-06 17:39 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 16:13 [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups Thomas Gleixner
2018-07-06 16:13 ` [patch 1/7] x86/kvmclock: Remove memblock dependency Thomas Gleixner
2018-07-06 16:13 ` [patch 2/7] x86/kvmclock: Remove page size requirement from wall_clock Thomas Gleixner
2018-07-12 2:15 ` Pavel Tatashin
2018-07-06 16:13 ` [patch 3/7] x86/kvmclock: Decrapify kvm_register_clock() Thomas Gleixner
2018-07-06 17:38 ` Paolo Bonzini
2018-07-06 17:39 ` Thomas Gleixner [this message]
2018-07-12 2:24 ` Pavel Tatashin
2018-07-06 16:13 ` [patch 4/7] x86/kvmclock: Cleanup the code Thomas Gleixner
2018-07-06 17:39 ` Paolo Bonzini
2018-07-09 9:05 ` Peter Zijlstra
2018-07-09 10:03 ` Thomas Gleixner
2018-07-09 11:32 ` Paolo Bonzini
2018-07-06 16:13 ` [patch 5/7] x86/kvmclock: Mark variables __initdata and __ro_after_init Thomas Gleixner
2018-07-12 2:31 ` Pavel Tatashin
2018-07-06 16:13 ` [patch 6/7] x86/kvmclock: Move kvmclock vsyscall param and init to kvmclock Thomas Gleixner
2018-07-06 17:43 ` Paolo Bonzini
2018-07-06 19:23 ` Thomas Gleixner
2018-07-12 2:52 ` Pavel Tatashin
2018-07-06 16:13 ` [patch 7/7] x86/kvmclock: Switch kvmclock data to a PER_CPU variable Thomas Gleixner
2018-07-12 3:12 ` Pavel Tatashin
2018-07-06 17:47 ` [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups Paolo Bonzini
2018-07-06 23:51 ` Brijesh Singh
2018-07-09 9:22 ` [patch 8/7] x86/kvmclock: Avoid TSC recalibration Peter Zijlstra
2018-07-12 2:12 ` [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups Pavel Tatashin
2018-07-13 22:51 ` Thomas Gleixner
2018-07-14 0:20 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1807061939120.1592@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=daniel.m.jordan@oracle.com \
--cc=jgross@suse.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pasha.tatashin@oracle.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=steven.sistare@oracle.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.