From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien.grall@arm.com>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org,
Stefano Stabellini <sstabellini@kernel.org>,
Julien Grall <julien@xen.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>
Subject: Re: [Xen-devel] [PATCH for-4.13] xen/arm: setup: Calculate correctly the size of Xen
Date: Wed, 16 Oct 2019 09:23:36 -0700 (PDT) [thread overview]
Message-ID: <alpine.DEB.2.21.1910160923220.30080@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <20191016111251.29214-1-julien.grall@arm.com>
On Wed, 16 Oct 2019, Julien Grall wrote:
> The current size of Xen is computed using _end - _start + 1. However,
> _end is pointing one past the end of Xen, so the size of Xen is
> off-by-one.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> xen/arch/arm/setup.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c
> index 705a917abf..51d32106b7 100644
> --- a/xen/arch/arm/setup.c
> +++ b/xen/arch/arm/setup.c
> @@ -819,7 +819,7 @@ void __init start_xen(unsigned long boot_phys_offset,
> /* Register Xen's load address as a boot module. */
> xen_bootmodule = add_boot_module(BOOTMOD_XEN,
> (paddr_t)(uintptr_t)(_start + boot_phys_offset),
> - (paddr_t)(uintptr_t)(_end - _start + 1), false);
> + (paddr_t)(uintptr_t)(_end - _start), false);
> BUG_ON(!xen_bootmodule);
>
> fdt_size = boot_fdt_info(device_tree_flattened, fdt_paddr);
> --
> 2.11.0
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-10-16 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 11:12 [Xen-devel] [PATCH for-4.13] xen/arm: setup: Calculate correctly the size of Xen Julien Grall
2019-10-16 11:14 ` Jürgen Groß
2019-10-16 16:23 ` Stefano Stabellini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1910160923220.30080@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=jgross@suse.com \
--cc=julien.grall@arm.com \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.