From: Thomas Gleixner <tglx@linutronix.de>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
y2038 Mailman List <y2038@lists.linaro.org>,
John Stultz <john.stultz@linaro.org>,
Paul Moore <paul@paul-moore.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
Linux kernel mailing list <linux-kernel@vger.kernel.org>,
Stephen Boyd <sboyd@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Ingo Molnar <mingo@kernel.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>,
Al Viro <viro@zeniv.linux.org.uk>,
SElinux list <selinux@vger.kernel.org>
Subject: Re: [PATCH 20/23] y2038: move itimer reset into itimer.c
Date: Thu, 14 Nov 2019 11:51:52 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911141149050.2507@nanos.tec.linutronix.de> (raw)
In-Reply-To: <CAFqZXNu4Tk4H3b_FS8=EA5QMi10kEgT22uD=61aDryHp-fXnig@mail.gmail.com>
On Thu, 14 Nov 2019, Ondrej Mosnacek wrote:
> On Mon, Nov 11, 2019 at 11:58 AM Arnd Bergmann <arnd@arndb.de> wrote:
> > I don't see that as a problem, we rarely put declarations inside of an #ifdef.
> > The main effect that would have is forcing any file that includes linux/time.h
> > to be rebuilt when selinux is turned on or off in the .config.
>
> OK, but with this patch if someone tries to use the function
> elsewhere, the build will succeed if SELinux is enabled in the config,
> but fail if it isn't. Is that intended? I would suggest at least
> clearly documenting it above the declaration that the function isn't
> supposed to be used by new users and doing so will cause build to fail
> under CONFIG_SECURITY_SELINUX=n.
Come on. We have enough functions in the kernel which are only available
under a certain config option and if you (ab)use them elsewhere then the
build fails. So what?
The #ifdef documents the limited scope and intended use clearly. If
something else really needs that function, then removing the #ifdef
shouldn't be rocket science either.
Thanks,
tglx
next prev parent reply other threads:[~2019-11-14 10:52 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 21:02 [PATCH 00/23] y2038 cleanups Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:02 ` Arnd Bergmann
2019-11-08 21:07 ` [PATCH 01/23] y2038: remove CONFIG_64BIT_TIME Arnd Bergmann
2019-11-20 22:28 ` [Y2038] " Ben Hutchings
2019-11-20 22:58 ` Dmitry Safonov
2019-11-08 21:07 ` [PATCH 02/23] y2038: add __kernel_old_timespec and __kernel_old_time_t Arnd Bergmann
2019-11-09 19:02 ` Deepa Dinamani
2019-11-20 22:30 ` [Y2038] " Ben Hutchings
2019-11-21 14:17 ` Arnd Bergmann
2019-11-08 21:07 ` [PATCH 03/23] y2038: vdso: change timeval to __kernel_old_timeval Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-13 21:56 ` Thomas Gleixner
2019-11-13 21:56 ` Thomas Gleixner
2019-11-13 21:56 ` Thomas Gleixner
2019-11-13 21:56 ` Thomas Gleixner
2019-11-08 21:07 ` [PATCH 04/23] y2038: vdso: change timespec to __kernel_old_timespec Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` [PATCH 05/23] y2038: vdso: change time_t to __kernel_old_time_t Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-13 21:57 ` Thomas Gleixner
2019-11-13 21:57 ` Thomas Gleixner
2019-11-08 21:07 ` [PATCH 06/23] y2038: vdso: nds32: open-code timespec_add_ns() Arnd Bergmann
2019-11-08 21:07 ` [PATCH 07/23] y2038: vdso: powerpc: avoid timespec references Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-20 22:43 ` [Y2038] " Ben Hutchings
2019-11-20 22:43 ` Ben Hutchings
2019-11-21 14:23 ` Arnd Bergmann
2019-11-21 14:23 ` Arnd Bergmann
2019-11-21 16:25 ` Christophe Leroy
2019-11-21 16:25 ` Christophe Leroy
2019-11-27 11:03 ` Arnd Bergmann
2019-11-27 11:03 ` Arnd Bergmann
2019-12-02 12:55 ` Christophe Leroy
2019-12-02 12:55 ` Christophe Leroy
2019-12-02 14:03 ` Arnd Bergmann
2019-12-02 14:03 ` Arnd Bergmann
2019-11-08 21:07 ` [PATCH 08/23] y2038: ipc: remove __kernel_time_t reference from headers Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-20 22:49 ` [Y2038] " Ben Hutchings
2019-11-20 22:49 ` Ben Hutchings
2019-11-20 22:49 ` Ben Hutchings
2019-11-21 14:28 ` [Y2038] " Arnd Bergmann
2019-11-21 14:28 ` Arnd Bergmann
2019-11-21 14:28 ` Arnd Bergmann
2019-11-21 14:28 ` Arnd Bergmann
2019-11-08 21:07 ` [PATCH 09/23] y2038: stat: avoid 'time_t' in 'struct stat' Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:07 ` Arnd Bergmann
2019-11-08 21:12 ` [PATCH 10/23] y2038: uapi: change __kernel_time_t to __kernel_old_time_t Arnd Bergmann
2019-11-09 19:03 ` Deepa Dinamani
2019-11-11 12:38 ` Christian Brauner
2019-11-08 21:12 ` [PATCH 11/23] y2038: rusage: use __kernel_old_timeval Arnd Bergmann
2019-11-12 21:09 ` Cyrill Gorcunov
2019-11-13 10:02 ` Arnd Bergmann
2019-11-13 17:22 ` Cyrill Gorcunov
2019-11-14 0:38 ` Christian Brauner
2019-11-14 0:38 ` Christian Brauner
2019-11-14 10:18 ` Arnd Bergmann
2019-11-14 10:23 ` Christian Brauner
2019-11-08 21:12 ` [PATCH 12/23] y2038: syscalls: change remaining timeval to __kernel_old_timeval Arnd Bergmann
2019-11-08 21:12 ` Arnd Bergmann
2019-11-11 12:44 ` Christian Brauner
2019-11-11 12:44 ` Christian Brauner
2019-11-11 12:44 ` Christian Brauner
2019-11-13 22:39 ` Rafael J. Wysocki
2019-11-13 22:39 ` Rafael J. Wysocki
2019-11-08 21:12 ` [PATCH 13/23] y2038: socket: remove timespec reference in timestamping Arnd Bergmann
2019-11-09 19:03 ` Deepa Dinamani
2019-11-11 20:24 ` Arnd Bergmann
2019-11-08 21:12 ` [PATCH 14/23] y2038: make ns_to_compat_timeval use __kernel_old_timeval Arnd Bergmann
2019-11-08 21:12 ` [PATCH 15/23] y2038: elfcore: Use __kernel_old_timeval for process times Arnd Bergmann
2019-11-08 21:12 ` [PATCH 16/23] y2038: timerfd: Use timespec64 internally Arnd Bergmann
2019-11-13 21:49 ` Thomas Gleixner
2019-11-08 21:12 ` [PATCH 17/23] y2038: time: avoid timespec usage in settimeofday() Arnd Bergmann
2019-11-13 21:53 ` Thomas Gleixner
2019-11-14 11:06 ` Arnd Bergmann
2019-11-14 11:06 ` Arnd Bergmann
2019-11-14 14:04 ` Thomas Gleixner
2019-11-14 14:04 ` Thomas Gleixner
2019-11-14 14:35 ` Arnd Bergmann
2019-11-14 23:01 ` Abel Vesa
2019-11-15 7:58 ` Arnd Bergmann
2019-11-15 10:27 ` Rasmus Villemoes
2019-11-15 13:50 ` Arnd Bergmann
2019-11-08 21:12 ` [PATCH 18/23] y2038: itimer: compat handling to itimer.c Arnd Bergmann
2019-11-13 21:54 ` Thomas Gleixner
2019-11-08 21:12 ` [PATCH 19/23] y2038: use compat_{get,set}_itimer on alpha Arnd Bergmann
2019-12-02 13:13 ` Guenter Roeck
2019-11-08 21:12 ` [PATCH 20/23] y2038: move itimer reset into itimer.c Arnd Bergmann
2019-11-09 13:43 ` Ondrej Mosnacek
2019-11-09 21:02 ` Arnd Bergmann
2019-11-09 23:07 ` Ondrej Mosnacek
2019-11-11 10:57 ` Arnd Bergmann
2019-11-14 8:51 ` Ondrej Mosnacek
2019-11-14 10:51 ` Thomas Gleixner [this message]
2019-11-13 22:03 ` Thomas Gleixner
2019-11-08 21:12 ` [PATCH 21/23] y2038: itimer: change implementation to timespec64 Arnd Bergmann
2019-11-13 22:28 ` Thomas Gleixner
2019-11-14 2:06 ` Steven Rostedt
2019-11-14 10:48 ` Thomas Gleixner
2019-11-14 10:52 ` Arnd Bergmann
2019-11-14 10:51 ` Arnd Bergmann
2019-11-14 10:57 ` Thomas Gleixner
2019-11-21 16:52 ` [Y2038] " Ben Hutchings
2019-11-25 20:26 ` Arnd Bergmann
2019-11-08 21:12 ` [PATCH 22/23] [RFC] y2038: itimer: use ktime_t internally Arnd Bergmann
2019-11-13 22:30 ` Thomas Gleixner
2019-11-08 21:12 ` [PATCH 23/23] y2038: allow disabling time32 system calls Arnd Bergmann
2019-11-11 12:31 ` Christian Brauner
2019-11-13 21:40 ` [PATCH 00/23] y2038 cleanups Arnd Bergmann
2019-11-13 21:40 ` Arnd Bergmann
2019-11-13 21:40 ` Arnd Bergmann
2019-11-13 21:40 ` Arnd Bergmann
2019-11-13 21:40 ` Arnd Bergmann
2019-11-13 21:40 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911141149050.2507@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=anna-maria@linutronix.de \
--cc=arnd@arndb.de \
--cc=bigeasy@linutronix.de \
--cc=eparis@parisplace.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=omosnace@redhat.com \
--cc=paul@paul-moore.com \
--cc=sboyd@kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.