From: Stefano Stabellini <sstabellini@kernel.org>
To: Julien Grall <julien@xen.org>
Cc: Bertrand Marquis <Bertrand.Marquis@arm.com>,
"open list:X86" <xen-devel@lists.xenproject.org>,
"alex.bennee@linaro.org" <alex.bennee@linaro.org>,
Andre Przywara <Andre.Przywara@arm.com>,
Rahul Singh <Rahul.Singh@arm.com>,
Julien Grall <Julien.Grall@arm.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Volodymyr Babchuk <Volodymyr_Babchuk@epam.com>,
Julien Grall <jgrall@amazon.com>
Subject: Re: [PATCH v3 1/2] xen/arm: gic: acpi: Use the correct length for the GICC structure
Date: Thu, 19 Nov 2020 15:49:10 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.21.2011191548450.7979@sstabellini-ThinkPad-T480s> (raw)
In-Reply-To: <1dfe3afc-55de-77ec-1f21-448c193909b4@xen.org>
[-- Attachment #1: Type: text/plain, Size: 860 bytes --]
On Thu, 19 Nov 2020, Julien Grall wrote:
> On 19/11/2020 15:22, Bertrand Marquis wrote:
> > Hi Julien,
>
> Hi Bertrand,
>
> >
> > > On 19 Nov 2020, at 12:13, Julien Grall <julien@xen.org> wrote:
> > >
> > > From: Julien Grall <julien.grall@arm.com>
> > >
> > > The length of the GICC structure in the MADT ACPI table differs between
> > > version 5.1 and 6.0, although there are no other relevant differences.
> > >
> > > Use the BAD_MADT_GICC_ENTRY macro, which was specifically designed to
> > > overcome this issue.
> > >
> >
> > The serie is braking the build on arm64 if ACPI is not activated:
> > arch/arm/gic.c:456: undefined reference to `acpi_gbl_FADT’
>
> :(. Sorry for that. I usually test with and without ACPI enabled but forgot to
> do for this series.
I just wanted to add that I checked and it looks like to converted all
places now
next prev parent reply other threads:[~2020-11-19 23:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 12:13 [PATCH v3 0/2] xen/arm: Allow Xen to boot with ACPI 5.1 Julien Grall
2020-11-19 12:13 ` [PATCH v3 1/2] xen/arm: gic: acpi: Use the correct length for the GICC structure Julien Grall
2020-11-19 15:22 ` Bertrand Marquis
2020-11-19 15:24 ` Julien Grall
2020-11-19 23:49 ` Stefano Stabellini [this message]
2020-11-19 12:13 ` [PATCH v3 2/2] xen/arm: acpi: Allow Xen to boot with ACPI 5.1 Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2011191548450.7979@sstabellini-ThinkPad-T480s \
--to=sstabellini@kernel.org \
--cc=Andre.Przywara@arm.com \
--cc=Bertrand.Marquis@arm.com \
--cc=Julien.Grall@arm.com \
--cc=Rahul.Singh@arm.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=alex.bennee@linaro.org \
--cc=jgrall@amazon.com \
--cc=julien@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.