From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] PCI: Sanitise firmware BAR assignments behind a PCI-PCI bridge
Date: Fri, 23 Sep 2022 01:38:41 +0100 (BST) [thread overview]
Message-ID: <alpine.DEB.2.21.2209230009020.29493@angie.orcam.me.uk> (raw)
In-Reply-To: <20220921225342.GA1233029@bhelgaas>
On Wed, 21 Sep 2022, Bjorn Helgaas wrote:
> > I have trimmed the change description down as you requested and left the
> > change proper unmodified, as discussed in my earlier response.
>
> I think this is great. It shouldn't have taken me this long, so
> thanks for persevering.
No worries, owing to various distractions it took me way too long to
iterate over this change too.
> I think we can use pci_upstream_bridge() as below. Let me know if
> not.
Based on how the helper has been documented I think you are right. Also
I have verified your branch with my hardware and it still works.
> Here it is as I applied to pci/resource for v6.1:
Thank you! I find your rewritten change description a pleasure to read.
I guess at this stage we'll never find out what the exact configuration
was that has lead to commit 351fc6d1a517 ("PCI: Fix starting basis for
resource requests"). At least it does not stand in the way.
What a mess it was with the firmware side of the earlier PCI systems even
once they've sorted the teething problems of the hardware side! I still
need to figure out how to get PCI interrupt routing to automagically work
in the I/O APIC mode with this x86 machine and its broken MP-table which
reports PCI interrupts as ISA interrupts, and then INTA only (at least our
PIRQ router code now handles PCI-to-PCI bridges in the PIC mode). And it
would have been so easy to get it right even with a fixed table (the BIOS
seems to build the table dynamically for no good reason even though the
wiring is fixed in hardware)!
Maciej
prev parent reply other threads:[~2022-09-23 0:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 19:49 [PATCH v3] PCI: Sanitise firmware BAR assignments behind a PCI-PCI bridge Maciej W. Rozycki
2022-09-21 22:53 ` Bjorn Helgaas
2022-09-23 0:38 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.2209230009020.29493@angie.orcam.me.uk \
--to=macro@orcam.me.uk \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.