Re: [RFC PATCH] ALSA: hda: call ext hda codec link up/down if available

From: Kai Vehmanen <kai.vehmanen@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>
Subject: Re: [RFC PATCH] ALSA: hda: call ext hda codec link up/down if available
Date: Thu, 4 Feb 2021 12:42:20 +0200 (EET)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2102041239160.864696@eliteleevi.tm.intel.com> (raw)
In-Reply-To: <s5hzh0k6vpn.wl-tiwai@suse.de>

Hey,

On Thu, 4 Feb 2021, Takashi Iwai wrote:

> On Thu, 04 Feb 2021 09:07:09 +0100, Kai Vehmanen wrote:
> > Takashi and others, this patch is a follow-up to the earlier thread about 
> > hdac link management:
> > https://mailman.alsa-project.org/pipermail/alsa-devel/2021-January/179715.html
> > 
> > We have absolutely no calls from sound/pci/hda/ to hdaudio_ext.h before
> > this patch, so I'm wondering if this is the right approach to take. 
> 
> An obvious drawback by this patch is that it'll make the hda-ext code
> always loaded whenever it's enabled, no matter whether it's really
> used or not.
> 
> Maybe adding a new callback (link) in hdac_bus_ops can help?

hmm, that's true. Let me try adding a separate callback and resend for 
review. That will look cleaner in hda_codec.c.

>> It does seem to be the natural path forward and mimics what was done in 
>> e.g. hdac_hdmi. But we want to keep reusing driver code for all HDA 
>> implementations, so adding hdac-ext support to codec drivers seem like the 
>> best path.
> 
> Yes, I find we're heading to the right direction.

Ack, thanks for the quick review.

br, Kai