Re: [XEN PATCH] docs/misra: add entries to exclude-list

From: Stefano Stabellini <sstabellini@kernel.org>
To: Federico Serafini <federico.serafini@bugseng.com>
Cc: xen-devel@lists.xenproject.org, consulting@bugseng.com,
	 Simone Ballarin <simone.ballarin@bugseng.com>,
	 Doug Goldstein <cardoe@cardoe.com>,
	 Stefano Stabellini <sstabellini@kernel.org>,
	 Andrew Cooper <andrew.cooper3@citrix.com>,
	 George Dunlap <george.dunlap@citrix.com>,
	Jan Beulich <jbeulich@suse.com>,  Julien Grall <julien@xen.org>,
	Wei Liu <wl@xen.org>
Subject: Re: [XEN PATCH] docs/misra: add entries to exclude-list
Date: Mon, 18 Dec 2023 17:43:13 -0800 (PST)	[thread overview]
Message-ID: <alpine.DEB.2.22.394.2312181743050.3175268@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <5df2a8c3c6daa0bec1b38f440fcd8fa3a380a1f6.1702900114.git.federico.serafini@bugseng.com>

On Mon, 18 Dec 2023, Federico Serafini wrote:
> Exclude efibind.h for all the architectures: it is used to build the
> efi stub, which is a separate entry point for Xen when booted from EFI
> firmware.
> Remove redundant entries from out_of_scope.ecl.
> 
> Exclude common/coverage: it is code to support gcov, hence it is part
> of the testing machinery.
> 
> Exclude decompress.h: file ported from Linux that defines a unique and
> documented interface towards all the (adopted) decompress functions.
> 
> Signed-off-by: Federico Serafini <federico.serafini@bugseng.com>

Acked-by: Stefano Stabellini <sstabellini@kernel.org>


> ---
>  .../eclair_analysis/ECLAIR/out_of_scope.ecl      |  5 -----
>  docs/misra/exclude-list.json                     | 16 ++++++++++++++++
>  2 files changed, 16 insertions(+), 5 deletions(-)
> 
> diff --git a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> index fd870716cf..9bcec4c69d 100644
> --- a/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> +++ b/automation/eclair_analysis/ECLAIR/out_of_scope.ecl
> @@ -17,11 +17,6 @@
>  -file_tag+={out_of_scope,"^xen/arch/x86/include/asm/intel-family\\.h$"}
>  -doc_end
>  
> --doc_begin="Files imported from the gnu-efi package"
> --file_tag+={adopted,"^xen/include/efi/.*$"}
> --file_tag+={adopted,"^xen/arch/x86/include/asm/x86_64/efibind\\.h$"}
> --doc_end
> -
>  -doc_begin="Build tools are out of scope."
>  -file_tag+={out_of_scope_tools,"^xen/tools/.*$"}
>  -file_tag+={out_of_scope_tools,"^xen/arch/x86/efi/mkreloc\\.c$"}
> diff --git a/docs/misra/exclude-list.json b/docs/misra/exclude-list.json
> index 48f671c548..83fae0b4a4 100644
> --- a/docs/misra/exclude-list.json
> +++ b/docs/misra/exclude-list.json
> @@ -1,6 +1,10 @@
>  {
>      "version": "1.0",
>      "content": [
> +        {
> +            "rel_path": "arch/*/include/asm/*/efibind.h",
> +            "comment": "Imported from gnu-efi package, ignore for now"
> +        },
>          {
>              "rel_path": "arch/arm/arm64/cpufeature.c",
>              "comment": "Imported from Linux, ignore for now"
> @@ -97,6 +101,10 @@
>              "rel_path": "arch/x86/efi/check.c",
>              "comment": "The resulting code is not included in the final Xen binary, ignore for now"
>          },
> +        {
> +            "rel_path": "common/coverage/*",
> +            "comment": "Files to support gcov, ignore for now"
> +        },
>          {
>              "rel_path": "common/bitmap.c",
>              "comment": "Imported from Linux, ignore for now"
> @@ -213,6 +221,14 @@
>              "rel_path": "include/xen/acpi.h",
>              "comment": "Imported from Linux, ignore for now"
>          },
> +        {
> +            "rel_path": "include/efi/*",
> +            "comment": "Imported from gnu-efi package, ignore for now"
> +        },
> +        {
> +            "rel_path": "include/xen/decompress.h",
> +            "comment": "Imported from Linux, ignore for now"
> +        },
>          {
>              "rel_path": "lib/list-sort.c",
>              "comment": "Imported from Linux, ignore for now"
> -- 
> 2.34.1
>