From: Stefano Stabellini <sstabellini@kernel.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Mykyta Poturai" <Mykyta_Poturai@epam.com>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
"Wei Liu" <wl@xen.org>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Juergen Gross" <jgross@suse.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Julien Grall" <julien@xen.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Michal Orzel" <michal.orzel@amd.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op
Date: Wed, 24 Jan 2024 16:01:27 -0800 (PST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2401241601130.7734@ubuntu-linux-20-04-desktop> (raw)
In-Reply-To: <dcf0fbe3-a95d-483f-a424-949c16805786@citrix.com>
[-- Attachment #1: Type: text/plain, Size: 558 bytes --]
On Wed, 24 Jan 2024, Andrew Cooper wrote:
> On 24/01/2024 1:07 am, Stefano Stabellini wrote:
> >> I agree with Jan that we could reuse
> >> xendevicemodel_inject_msi by assuing that PCI BDF zero is invalid.
>
> I've already explained why that will break future x86. (See the other
> thread off this patch for specifics).
>
> When we add vIOMMUs to guests, we *must* have correct source ids. 0 is
> ambiguous, so not safe to reuse.
>
>
> Allocating a new subop now is the only way to not shoot in the foot later.
OK, what you wrote makes sense to me.
next prev parent reply other threads:[~2024-01-25 0:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 10:01 [PATCH 0/2] Add support for MSI injection on Arm Mykyta Poturai
2024-01-14 10:01 ` [PATCH 1/2] arm: vgic: Add the ability to trigger MSIs from the Hypervisor Mykyta Poturai
2024-01-24 1:17 ` Stefano Stabellini
2024-01-24 11:21 ` Julien Grall
2024-01-24 11:41 ` Julien Grall
2024-01-14 10:01 ` [PATCH 2/2] xen/dm: arm: Introduce inject_msi2 DM op Mykyta Poturai
2024-01-15 9:35 ` Jan Beulich
2024-01-24 1:07 ` Stefano Stabellini
2024-01-24 20:50 ` Andrew Cooper
2024-01-25 0:01 ` Stefano Stabellini [this message]
2024-01-24 20:25 ` Andrew Cooper
2024-01-24 11:26 ` [PATCH 0/2] Add support for MSI injection on Arm Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2401241601130.7734@ubuntu-linux-20-04-desktop \
--to=sstabellini@kernel.org \
--cc=Mykyta_Poturai@epam.com \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=julien@xen.org \
--cc=michal.orzel@amd.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.