From: James Simmons <jsimmons@infradead.org>
To: lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH 00/34] Beginning of multi-rail support for drivers/staging/lustre
Date: Sat, 29 Sep 2018 23:35:19 +0100 (BST) [thread overview]
Message-ID: <alpine.LFD.2.21.1809292324070.25547@casper.infradead.org> (raw)
In-Reply-To: <87in2v4c16.fsf@notabene.neil.brown.name>
> > Signed-off-by: Amir Shehata <ashehata@whamcloud.com>
> > WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
> > Reviewed-on: http://review.whamcloud.com/18274
> > Reviewed-by: Doug Oucharek <dougso@me.com>
> > Reviewed-by: Olaf Weber <olaf.weber@hpe.com>
> > Signed-off-by: NeilBrown <neilb@suse.com>
>
> Thanks for the suggestion. I don't like that approach exactly because
> it seems to be a lie. The specific patch was not reviewed by those
> people, and there is useful information which is not included there.
> I have changed to patches to include:
>
> This is part of
> Commit: 8cbb8cd3e771 ("LU-7734 lnet: Multi-Rail local NI split")
> from upstream lustre, where it is marked:
> Signed-off-by: Amir Shehata <amir.shehata@intel.com>
> WC-bug-id: https://jira.whamcloud.com/browse/LU-7734
> Reviewed-on: http://review.whamcloud.com/18274
> Reviewed-by: Doug Oucharek <doug.s.oucharek@intel.com>
> Reviewed-by: Olaf Weber <olaf@sgi.com>
>
> checkpatch is not happy with the indented tags, but checkpatch is a
> servant, not the master.
To my knowledge their isn't really a policy about this. What I have been
doing is kind of following how LTS versions of lustre have been handled.
For LTS versions patches are cherry-picked and two additional lines are
added:
Lustre-change:
Lustre-commit:
The orginal reviews are keep. Also by including the original reviews the
people involved with those patches are poked. The only requirement is that
2 people review again. Not everyone has to review for it to land. Once
landed I don't see a clear why to tell who reviewed.
In any case the above approach seems reasonable as long as the original
author is preserve. The general rule is the original patch poster normally
keeps authorship. Also I noticed patches recently pushed are not reaching
the original authors and reviewers. We should make sure that still
happens.
prev parent reply other threads:[~2018-09-29 22:35 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 0:49 [lustre-devel] [PATCH 00/34] Beginning of multi-rail support for drivers/staging/lustre NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 11/34] lnet: pass tun to lnet_startup_lndni, instead of full conf NeilBrown
2018-09-11 18:31 ` Amir Shehata
2018-09-12 4:03 ` NeilBrown
2018-09-12 3:30 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 12/34] lnet: split lnet_startup_lndni NeilBrown
2018-09-12 3:39 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 16/34] lnet: lnet_shutdown_lndnets - remove some cleanup code NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 18/34] lnet: add ni_state NeilBrown
2018-09-12 3:59 ` Doug Oucharek
2018-09-12 4:25 ` NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 14/34] lnet: rename lnet_find_net_locked to lnet_find_rnet_locked NeilBrown
2018-09-12 3:40 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 09/34] lnet: add list of cpts to lnet_net NeilBrown
2018-09-10 23:28 ` Doug Oucharek
2018-09-12 2:16 ` NeilBrown
2018-09-11 1:02 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 06/34] lnet: store separate xmit/recv net-interface in each message NeilBrown
2018-09-10 23:24 ` Doug Oucharek
2018-09-10 23:29 ` James Simmons
2018-09-10 23:36 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 03/34] lnet: struct lnet_ni: move ni_lnd to lnet_net NeilBrown
2018-09-10 23:04 ` Doug Oucharek
2018-09-10 23:19 ` James Simmons
2018-09-10 23:19 ` Doug Oucharek
2018-09-10 23:19 ` James Simmons
2018-09-10 23:24 ` James Simmons
2018-09-10 23:25 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 15/34] lnet: extend zombie handling to nets and nis NeilBrown
2018-09-12 3:53 ` Doug Oucharek
2018-09-12 4:10 ` NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 02/34] lnet: Create struct lnet_net NeilBrown
2018-09-10 22:56 ` Doug Oucharek
2018-09-10 23:23 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 04/34] lnet: embed lnd_tunables in lnet_ni NeilBrown
2018-09-10 23:08 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 05/34] lnet: begin separating "networks" from "network interfaces" NeilBrown
2018-09-10 23:18 ` Doug Oucharek
2018-09-12 2:48 ` NeilBrown
2018-09-10 23:27 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 13/34] lnet: reverse order of lnet_startup_lnd{net, ni} NeilBrown
2018-09-12 3:39 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 10/34] lnet: add ni arg to lnet_cpt_of_nid() NeilBrown
2018-09-10 23:32 ` Doug Oucharek
2018-09-11 1:03 ` James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 01/34] struct lnet_ni - reformat comments NeilBrown
2018-09-10 22:49 ` Doug Oucharek
2018-09-10 23:17 ` James Simmons
2018-09-12 2:44 ` NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 07/34] lnet: change lnet_peer to reference the net, rather than ni NeilBrown
2018-09-10 23:17 ` James Simmons
2018-09-12 2:56 ` NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 08/34] lnet: add cpt to lnet_match_info NeilBrown
2018-09-10 23:25 ` Doug Oucharek
2018-09-11 1:01 ` James Simmons
2018-09-11 1:01 ` [lustre-devel] BRe: " James Simmons
2018-09-07 0:49 ` [lustre-devel] [PATCH 17/34] lnet: move lnet_shutdown_lndnets down to after first use NeilBrown
2018-09-12 3:55 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 20/34] lnet: discard ni_cpt_list NeilBrown
2018-09-12 4:07 ` Doug Oucharek
2018-09-12 5:48 ` NeilBrown
2018-09-13 19:33 ` Amir Shehata
2018-09-24 6:03 ` NeilBrown
2018-09-12 16:29 ` Amir Shehata
2018-09-07 0:49 ` [lustre-devel] [PATCH 34/34] lnet: introduce use_tcp_bonding mod param NeilBrown
2018-09-12 4:54 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 28/34] lnet: add checks to ensure network interface names are unique NeilBrown
2018-09-12 4:39 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 27/34] lnet: make it possible to add a new interface to a network NeilBrown
2018-09-12 4:38 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 30/34] lnet: fix typo NeilBrown
2018-09-12 4:47 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 33/34] Completely re-write lnet_parse_networks() NeilBrown
2018-09-12 4:54 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 32/34] lnet: lnet_dyn_del_ni: fix ping_info count NeilBrown
2018-09-12 4:49 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 22/34] lnet: don't take reference in lnet_XX2ni_locked() NeilBrown
2018-09-12 4:18 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 29/34] lnet: track tunables in lnet_startup_lndnet() NeilBrown
2018-09-12 4:47 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 23/34] lnet: don't need lock to test ln_shutdown NeilBrown
2018-09-12 4:27 ` Doug Oucharek
2018-09-12 5:54 ` NeilBrown
2018-09-07 0:49 ` [lustre-devel] [PATCH 26/34] lnet: only valid lnd_type when net_id is unique NeilBrown
2018-09-12 4:34 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 31/34] lnet: lnet_dyn_add_ni: fix ping_info count NeilBrown
2018-09-12 4:48 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 19/34] lnet: simplify lnet_islocalnet() NeilBrown
2018-09-12 4:02 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 25/34] lnet: swap 'then' and 'else' branches in lnet_startup_lndnet NeilBrown
2018-09-12 4:32 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 24/34] lnet: don't take lock over lnet_net_unique() NeilBrown
2018-09-12 4:29 ` Doug Oucharek
2018-09-07 0:49 ` [lustre-devel] [PATCH 21/34] lnet: add net_ni_added NeilBrown
2018-09-12 4:15 ` Doug Oucharek
2018-09-10 23:10 ` [lustre-devel] [PATCH 00/34] Beginning of multi-rail support for drivers/staging/lustre James Simmons
2018-09-24 6:58 ` NeilBrown
2018-09-29 22:35 ` James Simmons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1809292324070.25547@casper.infradead.org \
--to=jsimmons@infradead.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.