From: Jiri Kosina <jkosina@suse.cz>
To: Xing Wei <weixing@hanwang.com.cn>
Cc: linux-input <linux-input@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers/hid: the support for Hanwang tablet
Date: Wed, 11 Aug 2010 09:33:13 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1008110931240.2702@pobox.suse.cz> (raw)
In-Reply-To: <201008111148203123394@hanwang.com.cn>
On Wed, 11 Aug 2010, Xing Wei wrote:
> From: Xing Wei <weixing@hanwang.com.cn>
>
> This patch is the support for tablet of BeiJing HanwangTechnology Co, Ltd.
> The main purpose is to make the device taken over by our driver.
> The driver code will be submitted later.
>
> Signed-off-by: Xing Wei <weixing@hanwang.com.cn>
>
> ---
> This is our first time to submit the patch for linux.We'll really appreciate the comment and advice.
>
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-core.c devel/linux-2.6.35/drivers/hid/hid-core.c
> --- linux-2.6.35-vanilla/drivers/hid/hid-core.c 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-core.c 2010-08-11 18:20:13.832088816 +0800
> @@ -1759,6 +1759,11 @@ static bool hid_ignore(struct hid_device
> hdev->product <= USB_DEVICE_ID_SOUNDGRAPH_IMON_LAST)
> return true;
> break;
> + case USB_VENDOR_ID_HANWANG:
> + if (hdev->product >= USB_DEVICE_ID_HANWANG_TABLET_FIRST &&
> + hdev->product <= USB_DEVICE_ID_HANWANG_TABLET_LAST)
> + return true;
> + break;
> }
>
> if (hdev->type == HID_TYPE_USBMOUSE &&
> diff -uprN -X linux-2.6.35-vanilla/Documentation/dontdiff linux-2.6.35-vanilla/drivers/hid/hid-ids.h devel/linux-2.6.35/drivers/hid/hid-ids.h
> --- linux-2.6.35-vanilla/drivers/hid/hid-ids.h 2010-08-02 06:11:14.000000000 +0800
> +++ devel/linux-2.6.35/drivers/hid/hid-ids.h 2010-08-11 18:17:32.967089161 +0800
> @@ -526,5 +526,8 @@
> #define USB_DEVICE_ID_KYE_ERGO_525V 0x0087
> #define USB_DEVICE_ID_KYE_GPEN_560 0x5003
>
> +#define USB_VENDOR_ID_HANWANG 0x0b57
> +#define USB_DEVICE_ID_HANWANG_TABLET_LAST 0x8fff
> +#define USB_DEVICE_ID_HANWANG_TABLET_FIRST 0x5000
The patch is fine (I'd only suggest swapping 'LAST' and 'FIRST' lines here
to keep proper ordering), but I will be applying it only together with the
driver once you submit it, as it doesn't make sense stand-alone.
The driver is not HID-based (i.e. not using hid bus), but completely
standalone, right?
--
Jiri Kosina
SUSE Labs, Novell Inc.
next prev parent reply other threads:[~2010-08-11 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 3:48 [PATCH trivial] drivers/hid: the support for Hanwang tablet Xing Wei
2010-08-11 7:33 ` Jiri Kosina [this message]
2010-08-11 9:27 ` Re: [PATCH] " Xing Wei
2010-08-11 9:27 ` Xing Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1008110931240.2702@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=weixing@hanwang.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.