From: Jiri Kosina <jkosina@suse.cz>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: Simon Wood <simon@mungewell.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Marcin Tolysz <tolysz@gmail.com>
Subject: Re: [PATCH 1/2] sony_ff_hid_descriptor
Date: Tue, 7 Jun 2011 15:32:15 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1106071531330.22872@pobox.suse.cz> (raw)
In-Reply-To: <20110601214924.36ec42ad.ospite@studenti.unina.it>
On Wed, 1 Jun 2011, Antonio Ospite wrote:
> On Mon, 23 May 2011 03:19:58 -0700
> Simon Wood <simon@mungewell.org> wrote:
>
> > This patch modifies the HID descriptor to allow the reporting of
> > the accelerometers and gyro via a joystick axis.
>
> I am going to test it tomorrow, but for now I notice that the
> Signed-off-by is missing. Wait for the test before resending tho.
>
> Plus, the short commit message can be improved a little bit, and the
> long commit message could use the classic imperative form used in kernel
> commit messages: "Modify the HID descriptor to...", but these are just
> suggestions.
>
> Same comments for patch 2/2.
Antonio,
thanks for the (valid) comments.
What was the result of your testing of the patches, please?
Simon, would you please, once Antionio adds his Tested-by:, to resend with
proper authorship and Signed-off-by?
Thanks,
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2011-06-07 13:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 5:32 Byte swapping u16 data in HID report simon
2011-05-23 10:19 ` [PATCH 1/2] sony_ff_hid_descriptor Simon Wood
2011-05-23 10:19 ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood
2011-06-01 19:53 ` Antonio Ospite
2011-06-01 19:49 ` [PATCH 1/2] sony_ff_hid_descriptor Antonio Ospite
2011-06-07 13:32 ` Jiri Kosina [this message]
2011-06-07 13:32 ` Jiri Kosina
2011-06-07 14:12 ` Antonio Ospite
2011-06-07 15:53 ` simon
2011-06-07 19:40 ` Antonio Ospite
2011-05-23 10:23 ` Simon Wood
2011-05-23 10:23 ` [PATCH 2/2] sony_ff_byteswap_accelerometer Simon Wood
2011-06-01 10:58 ` Byte swapping u16 data in HID report Antonio Ospite
2011-06-01 15:02 ` simon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1106071531330.22872@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ospite@studenti.unina.it \
--cc=simon@mungewell.org \
--cc=tolysz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.