From: Jiri Kosina <jkosina@suse.cz>
To: Axel Lin <axel.lin@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Don Prince <dhprince.devel@yahoo.co.uk>,
linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: prodikeys: make needlessly global symbols static
Date: Thu, 21 Jul 2011 13:59:42 +0200 (CEST) [thread overview]
Message-ID: <alpine.LNX.2.00.1107211359300.7300@pobox.suse.cz> (raw)
In-Reply-To: <1311232893.10976.1.camel@phoenix>
On Thu, 21 Jul 2011, Axel Lin wrote:
> The following symbols are not referenced outside this file so
> there's no need for it to be in the global name space.
>
> pcmidi_sustained_note_release
> init_sustain_timers
> stop_sustain_timers
> pcmidi_handle_report
> pcmidi_setup_extra_keys
> pcmidi_snd_initialise
> pcmidi_snd_terminate
>
> Make them static.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Applied, thanks.
--
Jiri Kosina
SUSE Labs
prev parent reply other threads:[~2011-07-21 11:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-21 7:21 [PATCH] HID: prodikeys: make needlessly global symbols static Axel Lin
2011-07-21 11:59 ` Jiri Kosina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1107211359300.7300@pobox.suse.cz \
--to=jkosina@suse.cz \
--cc=axel.lin@gmail.com \
--cc=dhprince.devel@yahoo.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.