Re: [PATCH 0/4] HID: implement new transport-driver callbacks

From: Jiri Kosina <jkosina@suse.cz>
To: Frank Praznik <frank.praznik@oh.rr.com>
Cc: linux-input@vger.kernel.org, dh.herrmann@gmail.com
Subject: Re: [PATCH 0/4] HID: implement new transport-driver callbacks
Date: Wed, 29 Jan 2014 14:25:12 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1401291424560.21385@pobox.suse.cz> (raw)
In-Reply-To: <1390416584-3667-1-git-send-email-frank.praznik@oh.rr.com>

On Wed, 22 Jan 2014, Frank Praznik wrote:

> These patches are originally the work of David Herrmann who suggested that I 
> update and submit them as their functionality is required for some pending
> patches to the hid-sony driver.
> 
> These patches implement the SET/GET_REPORT and raw intr OUTPUT requests for all
> transport drivers.  It adds two callbacks to the hid_ll_driver struct:
> 
> int (*raw_request)(struct hid_device *hdev, unsigned char reportnum,
> 		   __u8 *buf, size_t len, unsigned char rtype, int reqtype);
> 
> int (*output_report)(struct hid_device *hdev, __u8 *buf, size_t len);
> 
> along with the necessary support fuctions in the USBHID, and HIDP drivers.
> 
> UHID is not converted yet.

I have finished reviewing the patchset and don't have any objections. I am 
queuing them for 3.15.

-- 
Jiri Kosina
SUSE Labs