All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Kosina <jikos@kernel.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-input@vger.kernel.org
Subject: Re: [PATCH] usbhid: discarded events don't abort idleness
Date: Fri, 20 Nov 2015 11:00:37 +0100 (CET)	[thread overview]
Message-ID: <alpine.LNX.2.00.1511201059520.20111@pobox.suse.cz> (raw)
In-Reply-To: <1446724527-27736-1-git-send-email-oneukum@suse.com>

On Thu, 5 Nov 2015, Oliver Neukum wrote:

> If an event is discarded the device stays idle.
> Just reverse the order of check and marking busy.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>

Hi Oliver,

thanks for the fix. This is a real bug, so I am wondering whether you have 
seen causing it real problems (and hence it should be merged for 4.4), or 
if you found it just by code inspection (and therefore it should be fine 
to merge it for 4.5).

Thanks,

-- 
Jiri Kosina
SUSE Labs


  reply	other threads:[~2015-11-20 10:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 11:55 [PATCH] usbhid: discarded events don't abort idleness Oliver Neukum
2015-11-20 10:00 ` Jiri Kosina [this message]
2015-11-23  9:17   ` Oliver Neukum
2015-11-23 14:47 ` Jiri Kosina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1511201059520.20111@pobox.suse.cz \
    --to=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.