All of lore.kernel.org
 help / color / mirror / Atom feed
From: Finn Thain <fthain@telegraphics.com.au>
To: NeilBrown <neilb@suse.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>,
	linux-nvdimm@lists.01.org, linux-block@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-scsi@vger.kernel.org,
	Jens Axboe <axboe@fb.com>, Jeff Moyer <jmoyer@redhat.com>,
	James Bottomley <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH v4 0/3] Badblock tracking for gendisks
Date: Wed, 9 Dec 2015 08:52:35 +1100 (AEDT)	[thread overview]
Message-ID: <alpine.LNX.2.00.1512090848001.2126@nippy.intranet> (raw)
In-Reply-To: <87poygsmxd.fsf@notabene.neil.brown.name>


On Wed, 9 Dec 2015, NeilBrown wrote:

> On Wed, Dec 09 2015, Vishal Verma <vishal.l.verma@intel.com> wrote:
> 
> >
> > Patch 3 converts md over to use the new badblocks 'library'. I have 
> > done some pretty simple testing on this - created a raid 1 device, 
> > made sure the sysfs entries show up, and can be used to add and view 
> > badblocks. A closer look by the md folks would be nice here.
> 
> Hi,
>  this all looks reasonably sensible.  I haven't gone over it with a
>  fine toothed comb (I wonder where that analogy comes from....)

Delousing. (Not debugging.)

> but
>  nothing is obviously wrong.
> 
>  Acked-by: NeilBrown <neilb@suse.com>
> 
> Thanks,
> NeilBrown
> 

-- 

  reply	other threads:[~2015-12-08 21:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-08 19:18 [PATCH v4 0/3] Badblock tracking for gendisks Vishal Verma
2015-12-08 19:18 ` [PATCH v4 1/3] badblocks: Add core badblock management code Vishal Verma
2015-12-08 19:18 ` [PATCH v4 2/3] block: Add badblock management for gendisks Vishal Verma
2015-12-08 19:18 ` [PATCH v4 3/3] md: convert to use the generic badblocks code Vishal Verma
2015-12-08 20:30 ` [PATCH v4 0/3] Badblock tracking for gendisks NeilBrown
2015-12-08 21:52   ` Finn Thain [this message]
2015-12-11  5:40 ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LNX.2.00.1512090848001.2126@nippy.intranet \
    --to=fthain@telegraphics.com.au \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=axboe@fb.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=neilb@suse.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.