From: Jiri Kosina <jikos@kernel.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Josh Poimboeuf <jpoimboe@redhat.com>,
Geliang Tang <geliangtang@163.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com>,
Josh Triplett <josh@joshtriplett.org>,
Seth Jennings <sjenning@redhat.com>,
Vojtech Pavlik <vojtech@suse.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] list: introduce list_is_first()
Date: Thu, 10 Dec 2015 17:47:19 +0100 (CET) [thread overview]
Message-ID: <alpine.LNX.2.00.1512101745360.9922@cbobk.fhfr.pm> (raw)
In-Reply-To: <56699BA8.1010009@kernel.dk>
On Thu, 10 Dec 2015, Jens Axboe wrote:
> It's a balance, as we also should not make APIs out of everything. As I said,
> purely my opinion, but I think the is_last/is_first have jumped the shark.
I don't have a strong opinion either way.
What I think we should do though, is to either have both (i.e accept this
patchset) or have neither of them (i.e. drop list_is_last()).
Otherwise people are likely to be confused by such an asymetric API and
will keep posting patches for it over and over again.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2015-12-10 16:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:17 [PATCH 1/4] list: introduce list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 2/4] livepatch: use list_is_first() Geliang Tang
2015-12-10 14:17 ` [PATCH 3/4] netfilter: ipset: " Geliang Tang
2015-12-10 14:20 ` [PATCH 4/4] elevator: use list_is_{first,last} Geliang Tang
2015-12-10 15:10 ` [PATCH 1/4] list: introduce list_is_first() Jens Axboe
2015-12-10 15:23 ` Josh Poimboeuf
2015-12-10 15:35 ` Jens Axboe
2015-12-10 16:47 ` Jiri Kosina [this message]
2015-12-10 15:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1512101745360.9922@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=axboe@kernel.dk \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=geliangtang@163.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.