From: Alan Maguire <alan.maguire@oracle.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Alan Maguire <alan.maguire@oracle.com>,
linux-kselftest@vger.kernel.org, brendanhiggins@google.com,
skhan@linuxfoundation.org, mcgrof@kernel.org,
keescook@chromium.org, yzaikin@google.com,
akpm@linux-foundation.org, yamada.masahiro@socionext.com,
catalin.marinas@arm.com, joe.lawrence@redhat.com,
penguin-kernel@i-love.sakura.ne.jp, schowdary@nvidia.com,
urezki@gmail.com, changbin.du@intel.com,
kunit-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Knut Omang <knut.omang@oracle.com>,
rdunlap@infradead.org
Subject: Re: [PATCH linux-kselftest-test 2/3] kunit: allow kunit to be loaded as a module
Date: Tue, 8 Oct 2019 16:15:09 +0100 (BST) [thread overview]
Message-ID: <alpine.LRH.2.20.1910081611050.839@dhcp-10-175-191-48.vpn.oracle.com> (raw)
In-Reply-To: <20191008145552.GS32742@smile.fi.intel.com>
On Tue, 8 Oct 2019, Andy Shevchenko wrote:
> On Tue, Oct 08, 2019 at 03:43:51PM +0100, Alan Maguire wrote:
> > Making kunit itself buildable as a module allows for "always-on"
> > kunit configuration; specifying CONFIG_KUNIT=m means the module
> > is built but only used when loaded. Kunit test modules will load
> > kunit.ko as an implicit dependency, so simply running
> > "modprobe my-kunit-tests" will load the tests along with the kunit
> > module and run them.
>
> > +#ifdef MODULE
>
> > +#endif /* MODULE */
>
> This is strange. Why do you need ifdef?
>
Ah, this was an incorrect assumption on my part; I thought that
declaring a module license for built-in code might trigger a warning
during build. I'll remove the #ifdef MODULE around licenses in v3 (v2 has
already gone out as I mistakenly initially sent the wrong version of the
patches). I've verified that removing it triggers no warnings.
Thanks to you and Randy for spotting this!
Alan
> --
> With Best Regards,
> Andy Shevchenko
>
>
>
next prev parent reply other threads:[~2019-10-08 15:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 14:43 [PATCH linux-kselftest-test 0/3] kunit: support module-based build Alan Maguire
2019-10-08 14:43 ` [PATCH linux-kselftest-test 1/3] kunit: allow kunit tests to be loaded as a module Alan Maguire
2019-10-08 14:43 ` [PATCH linux-kselftest-test 2/3] kunit: allow kunit " Alan Maguire
2019-10-08 14:55 ` Andy Shevchenko
2019-10-08 15:15 ` Alan Maguire [this message]
2019-10-08 14:43 ` [PATCH linux-kselftest-test 3/3] kunit: update documentation to describe module-based build Alan Maguire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.20.1910081611050.839@dhcp-10-175-191-48.vpn.oracle.com \
--to=alan.maguire@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=brendanhiggins@google.com \
--cc=catalin.marinas@arm.com \
--cc=changbin.du@intel.com \
--cc=joe.lawrence@redhat.com \
--cc=keescook@chromium.org \
--cc=knut.omang@oracle.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=rdunlap@infradead.org \
--cc=schowdary@nvidia.com \
--cc=skhan@linuxfoundation.org \
--cc=urezki@gmail.com \
--cc=yamada.masahiro@socionext.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.