From: James Morris <jmorris@namei.org>
To: Micah Morton <mortonm@chromium.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Kees Cook <keescook@chromium.org>,
Casey Schaufler <casey@schaufler-ca.com>,
Stephen Smalley <sds@tycho.nsa.gov>,
linux-security-module <linux-security-module@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] LSM: SafeSetID: gate setgid transitions
Date: Tue, 5 Mar 2019 14:30:49 +1100 (AEDT) [thread overview]
Message-ID: <alpine.LRH.2.21.1903051429300.20560@namei.org> (raw)
In-Reply-To: <CAJ-EccMu97tZCWXTakcTwqFwzXdzVDedgc3jWaRvaJu-duH6tQ@mail.gmail.com>
On Mon, 4 Mar 2019, Micah Morton wrote:
> > + case LSM_SETGID_RE:
> > + break;
> > + case LSM_SETGID_ID:
> > + break;
> > + case LSM_SETGID_RES:
> > + break;
> > + case LSM_SETGID_FS:
> > + break;
> > +
These should be collapsed into multiple case statements with one break.
Also, please start a new thread when you post a new version of the
patchset, and include all of the series in each version.
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2019-03-05 3:30 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 22:22 [PATCH 2/2] LSM: SafeSetID: gate setgid transitions mortonm
2019-02-17 18:49 ` Serge E. Hallyn
2019-02-19 17:04 ` Micah Morton
2019-02-19 18:26 ` Serge E. Hallyn
2019-02-19 23:30 ` Micah Morton
2019-02-19 23:40 ` [PATCH v2 " mortonm
2019-02-25 22:35 ` Serge E. Hallyn
2019-02-26 18:00 ` [PATCH v3 " mortonm
2019-02-26 18:03 ` [PATCH v2 " Micah Morton
2019-02-27 20:00 ` [PATCH v2 1/2] " mortonm
2019-02-28 3:11 ` Serge E. Hallyn
2019-02-28 16:50 ` Casey Schaufler
2019-02-28 19:06 ` [PATCH v3 " mortonm
2019-02-28 19:12 ` Casey Schaufler
2019-02-28 20:20 ` [PATCH v4 2/2] " mortonm
2019-02-28 22:50 ` Casey Schaufler
2019-02-28 23:55 ` [PATCH v4 1/2] " mortonm
2019-03-04 18:10 ` Micah Morton
2019-03-04 18:27 ` [PATCH v5 " mortonm
2019-03-05 3:30 ` James Morris [this message]
2019-03-05 15:46 ` [PATCH v4 " Micah Morton
2019-02-28 19:08 ` [PATCH v2 " Micah Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.2.21.1903051429300.20560@namei.org \
--to=jmorris@namei.org \
--cc=casey@schaufler-ca.com \
--cc=keescook@chromium.org \
--cc=linux-security-module@vger.kernel.org \
--cc=mortonm@chromium.org \
--cc=sds@tycho.nsa.gov \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.