alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: Bard Liao <yung-chuan.liao@linux.intel.com>,
	alsa-devel@alsa-project.org,  vkoul@kernel.org
Cc: linux-kernel@vger.kernel.org, vinod.koul@linaro.org,
	gregkh@linuxfoundation.org, pierre-louis.bossart@linux.intel.com,
	ranjani.sridharan@linux.intel.com, hui.wang@canonical.com,
	srinivas.kandagatla@linaro.org, jank@cadence.com,
	mengdong.lin@intel.com, sanyog.r.kale@intel.com,
	rander.wang@linux.intel.com, bard.liao@intel.com
Subject: Re: [PATCH] soundwire: Add generic bandwidth allocation algorithm
Date: Wed, 16 Sep 2020 10:29:52 +0200	[thread overview]
Message-ID: <02abf228-f331-61fb-d8f6-d1df4b2f54a3@perex.cz> (raw)
In-Reply-To: <fdf22a3c-457f-09ef-8dc5-c0f3871cf2ce@perex.cz>

Dne 09. 09. 20 v 8:26 Jaroslav Kysela napsal(a):
> Dne 08. 09. 20 v 15:15 Bard Liao napsal(a):
>> This algorithm computes bus parameters like clock frequency, frame
>> shape and port transport parameters based on active stream(s) running
>> on the bus.
>>
>> Developers can also implement their own .compute_params() callback for
>> specific resource management algorithm, and set if before calling
>> sdw_add_bus_master()
>>
>> Credits: this patch is based on an earlier internal contribution by
>> Vinod Koul, Sanyog Kale, Shreyas Nc and Hardik Shah. All hard-coded
>> values were removed from the initial contribution to use BIOS
>> information instead.
>>
>> Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
>> ---
>>  drivers/soundwire/Kconfig                     |   5 +
>>  drivers/soundwire/Makefile                    |   3 +
>>  drivers/soundwire/bus.c                       |   6 +
>>  drivers/soundwire/bus.h                       |  46 +-
>>  .../soundwire/generic_bandwidth_allocation.c  | 427 ++++++++++++++++++
>>  drivers/soundwire/intel.c                     |   3 +
>>  drivers/soundwire/stream.c                    |  12 +
>>  include/linux/soundwire/sdw.h                 |   3 +
>>  8 files changed, 503 insertions(+), 2 deletions(-)
>>  create mode 100644 drivers/soundwire/generic_bandwidth_allocation.c
> 
> I did testing and I've not found any issues. The abstraction looks good.
> 
> Acked-by: Jaroslav Kysela <perex@perex.cz>
> 

Vinod, ping.... This is the last patch which is missing to get the soundwire
audio working on some Intel hardware platforms (laptops) which are already on
the market.

				Thank you,
					Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.

  reply	other threads:[~2020-09-16  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-08 13:15 [PATCH] soundwire: Add generic bandwidth allocation algorithm Bard Liao
2020-09-09  6:26 ` Jaroslav Kysela
2020-09-16  8:29   ` Jaroslav Kysela [this message]
2020-09-18 12:00 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02abf228-f331-61fb-d8f6-d1df4b2f54a3@perex.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=bard.liao@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hui.wang@canonical.com \
    --cc=jank@cadence.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mengdong.lin@intel.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=rander.wang@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vinod.koul@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).