From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7272AC282DD for ; Fri, 10 Jan 2020 16:25:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85F93206ED for ; Fri, 10 Jan 2020 16:25:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="gVDPvYvi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85F93206ED Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7065B1682; Fri, 10 Jan 2020 17:24:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7065B1682 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1578673516; bh=4k3fIxVYgno+tIOTp8pOZJm21RHdBQZNyBim2MtTyN8=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=gVDPvYvijS6n8WLNjWkPFuBrP9rFJOL5Y6oq7KuO3Z6kVRXrwBA4M/J4MZd+E7Yun eTO/3Q8OS1IDPX2ALzHckj1TiqfNRcIKrEEc2yrr/t6wlLXUlPnxG06vrNDjQ9yHK6 4kkOd0Kb9BXJtc8EFmnYhsI9k8YZhL0m9t92cagA= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id E2CDEF8010B; Fri, 10 Jan 2020 17:24:25 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 87F78F8010B; Fri, 10 Jan 2020 17:24:24 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4B44FF8010B for ; Fri, 10 Jan 2020 17:24:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4B44FF8010B X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2020 08:24:18 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,417,1571727600"; d="scan'208";a="224240060" Received: from nehudak-mobl1.amr.corp.intel.com (HELO [10.251.145.164]) ([10.251.145.164]) by orsmga003.jf.intel.com with ESMTP; 10 Jan 2020 08:24:11 -0800 To: Vinod Koul References: <20200108175438.13121-1-pierre-louis.bossart@linux.intel.com> <20200108175438.13121-7-pierre-louis.bossart@linux.intel.com> <20200110070321.GA2818@vkoul-mobl> From: Pierre-Louis Bossart Message-ID: <0553dba8-6a08-93c7-d0d5-4d2ca6a67f56@linux.intel.com> Date: Fri, 10 Jan 2020 10:24:10 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200110070321.GA2818@vkoul-mobl> Content-Language: en-US Cc: alsa-devel@alsa-project.org, tiwai@suse.de, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Ranjani Sridharan , broonie@kernel.org, srinivas.kandagatla@linaro.org, jank@cadence.com, slawomir.blauciak@intel.com, Sanyog Kale , Rander Wang , Bard liao , Rander Wang Subject: Re: [alsa-devel] [PATCH 6/6] soundwire: stream: don't program ports for a stream that has not been prepared X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >> GitHub issue: https://github.com/thesofproject/linux/issues/1637 > > This is not relevant for kernel, pls remove Why? it's not uncommon to have bugzilla links, why would we lose the publicly-available information because GitHub is used? >> list_for_each_entry(m_rt, &bus->m_rt_list, bus_node) { >> + >> + /* >> + * this loop walks through all master runtimes for a >> + * bus, but the ports can only be configured while >> + * explicitly preparing a stream or handling an >> + * already-prepared stream otherwise. > > we can go upto 80 chars, make sure you align the above comment block as > such this is formatted by emacs, and with long words you get spaces at the end. >> /* Program params */ >> - ret = sdw_program_params(bus); >> + ret = sdw_program_params(bus, false); > > Can you do a converse test as well, when the streams are running and > concurrently two stream are stopped, it would be good to get it confirmed... we cannot concurrently stop two streams since we take a bus lock. That's a problem but it'll have to be addressed separately. the problem with multiple streams addressed here is when one is CONFIGURED, which does not require a bus lock. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel