From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [alsa-devel] [PATCH 09/10] ASoC: soc-pcm: care Multi Codec at soc_dpcm_fe_runtime_update()
Date: Thu, 13 Feb 2020 10:10:16 -0600 [thread overview]
Message-ID: <09d31018-abdf-0383-ac55-29cc7d5ad103@linux.intel.com> (raw)
In-Reply-To: <87y2t7qfi9.wl-kuninori.morimoto.gx@renesas.com>
On 2/12/20 10:26 PM, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> soc_dpcm_fe_runtime_update() doesn't care Multi Codec now.
> We need to care it. This patch fixup it.
Humm, maybe a stupid question but for my education is there an actual
case where a front-end dailink uses more that one codec_dai? All the
examples I see for Intel rely on COMP_DUMMY().
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/soc-pcm.c | 24 ++++++++++++++++++------
> 1 file changed, 18 insertions(+), 6 deletions(-)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index 95fe915f26b0..962fe6cb7d3e 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -2614,8 +2614,10 @@ static int dpcm_run_old_update(struct snd_soc_pcm_runtime *fe, int stream)
>
> static int soc_dpcm_fe_runtime_update(struct snd_soc_pcm_runtime *fe, int new)
> {
> + struct snd_soc_dai *codec_dai;
> struct snd_soc_dapm_widget_list *list;
> int count, paths;
> + int i;
>
> if (!fe->dai_link->dynamic)
> return 0;
> @@ -2629,13 +2631,18 @@ static int soc_dpcm_fe_runtime_update(struct snd_soc_pcm_runtime *fe, int new)
> new ? "new" : "old", fe->dai_link->name);
>
> /* skip if FE doesn't have playback capability */
> - if (!snd_soc_dai_stream_valid(fe->cpu_dai, SNDRV_PCM_STREAM_PLAYBACK) ||
> - !snd_soc_dai_stream_valid(fe->codec_dai, SNDRV_PCM_STREAM_PLAYBACK))
> + if (!snd_soc_dai_stream_valid(fe->cpu_dai, SNDRV_PCM_STREAM_PLAYBACK))
> goto capture;
> + for_each_rtd_codec_dai(fe, i, codec_dai)
> + if (!snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_PLAYBACK))
> + goto capture;
>
> /* skip if FE isn't currently playing */
> - if (!fe->cpu_dai->playback_active || !fe->codec_dai->playback_active)
> + if (!fe->cpu_dai->playback_active)
> goto capture;
> + for_each_rtd_codec_dai(fe, i, codec_dai)
> + if (!codec_dai->playback_active)
> + goto capture;
>
> paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_PLAYBACK, &list);
> if (paths < 0) {
> @@ -2660,13 +2667,18 @@ static int soc_dpcm_fe_runtime_update(struct snd_soc_pcm_runtime *fe, int new)
>
> capture:
> /* skip if FE doesn't have capture capability */
> - if (!snd_soc_dai_stream_valid(fe->cpu_dai, SNDRV_PCM_STREAM_CAPTURE) ||
> - !snd_soc_dai_stream_valid(fe->codec_dai, SNDRV_PCM_STREAM_CAPTURE))
> + if (!snd_soc_dai_stream_valid(fe->cpu_dai, SNDRV_PCM_STREAM_CAPTURE))
> return 0;
> + for_each_rtd_codec_dai(fe, i, codec_dai)
> + if (!snd_soc_dai_stream_valid(codec_dai, SNDRV_PCM_STREAM_CAPTURE))
> + return 0;
>
> /* skip if FE isn't currently capturing */
> - if (!fe->cpu_dai->capture_active || !fe->codec_dai->capture_active)
> + if (!fe->cpu_dai->capture_active)
> return 0;
> + for_each_rtd_codec_dai(fe, i, codec_dai)
> + if (!codec_dai->capture_active)
> + return 0;
>
> paths = dpcm_path_get(fe, SNDRV_PCM_STREAM_CAPTURE, &list);
> if (paths < 0) {
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2020-02-13 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 4:25 [alsa-devel] [PATCH 00/10] ASoC: soc-pcm cleanup step3 Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 01/10] ASoC: soc-pcm: move dai_get_widget() Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 02/10] ASoC: soc-pcm: use dai_get_widget() at dpcm_get_be() Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 03/10] ASoC: soc-pcm: use dai_get_widget() at dpcm_end_walk_at_be() Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 04/10] ASoC: soc-pcm: use dpcm_get_be() " Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 05/10] ASoC: soc-pcm: remove soc_dpcm_be_digital_mute() Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 06/10] ASoC: soc-pcm: remove snd_soc_dpcm_be_get/set_state() Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 07/10] ASoC: soc-pcm: add snd_soc_dpcm_can_be() and remove duplicate code Kuninori Morimoto
2020-02-13 15:56 ` Pierre-Louis Bossart
2020-02-14 0:04 ` Kuninori Morimoto
2020-02-13 17:15 ` Ranjani Sridharan
2020-02-14 0:08 ` Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 08/10] ASoC: soc-pcm: use goto and remove multi return Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 09/10] ASoC: soc-pcm: care Multi Codec at soc_dpcm_fe_runtime_update() Kuninori Morimoto
2020-02-13 16:10 ` Pierre-Louis Bossart [this message]
2020-02-14 0:07 ` Kuninori Morimoto
2020-02-13 4:26 ` [alsa-devel] [PATCH 10/10] ASoC: soc.h: add for_each_pcm_stream() Kuninori Morimoto
2020-02-13 6:35 ` Takashi Iwai
2020-02-13 6:46 ` Kuninori Morimoto
2020-02-13 16:14 ` Pierre-Louis Bossart
2020-02-14 0:05 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d31018-abdf-0383-ac55-29cc7d5ad103@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).