From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Keith Tzneg <matsufan@gmail.com>, alsa-devel@alsa-project.org
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Mac Chiang <mac.chiang@intel.com>,
Libin Yang <libin.yang@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Fred Oh <fred.oh@linux.intel.com>,
Keith Tzeng <keith.tzeng@quanta.corp-partner.google.com>,
Rander Wang <rander.wang@linux.intel.com>,
Yong Zhi <yong.zhi@intel.com>, Mark Brown <broonie@kernel.org>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
Naveen Manohar <naveen.m@intel.com>,
Brent Lu <brent.lu@intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: Intel: boards: Add CML_RT1015 m/c driver
Date: Mon, 26 Oct 2020 14:22:13 -0500 [thread overview]
Message-ID: <0ade3e3c-c55d-d137-0af2-b2b32c16cfd7@linux.intel.com> (raw)
In-Reply-To: <1603515087-4092-1-git-send-email-keith.tzeng@quantatw.com>
On 10/23/20 11:51 PM, Keith Tzneg wrote:
> From: Keith Tzeng <keith.tzeng@quanta.corp-partner.google.com>
>
> Machine driver to enable RT5682 on SSP0, DMIC, HDMI and RT1015 AMP on
> SSP1: Enabled 4 CH TDM playback with 24 bit data.
Same comment for the third time: there is no reason to add an entire
machine driver just to replace one amplifier by another.
let's use an existing machine driver and use a quirk (DMI or table_id)
to select the relevant amp for that device.
prev parent reply other threads:[~2020-10-26 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 4:51 [PATCH v3] ASoC: Intel: boards: Add CML_RT1015 m/c driver Keith Tzneg
2020-10-26 19:22 ` Pierre-Louis Bossart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ade3e3c-c55d-d137-0af2-b2b32c16cfd7@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=keith.tzeng@quanta.corp-partner.google.com \
--cc=krzk@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=libin.yang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=matsufan@gmail.com \
--cc=naveen.m@intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
--cc=yang.jie@linux.intel.com \
--cc=yong.zhi@intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).