From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89A3DC33CB1 for ; Thu, 16 Jan 2020 07:43:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 11D0B2075B for ; Thu, 16 Jan 2020 07:43:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="oCXjClzG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 11D0B2075B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5CA79179D; Thu, 16 Jan 2020 08:42:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5CA79179D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579160597; bh=JQtSwJK20PRWUMkyyzRdfK/0GY3xcBsmTwJEze1JP3w=; h=From:To:Date:References:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=oCXjClzGHcXm/Za3QY4+Pc/g0HlMkWbCJdXrtTF7nhELOMHM6xIkE2EO3iU3zWbZJ 5PtKIgpIWHetcg6bQ1vAYpu/1obuRSdEAiEOVQUAtplW+8tB45HARhFtFOrMNj+EC1 Gcs+eTE8Hdw7ffDrs3SSFbMYDltRsrX3D0FKXCgw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B5073F8014D; Thu, 16 Jan 2020 08:42:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id AA4A4F8014D; Thu, 16 Jan 2020 08:42:23 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CFAECF800E9 for ; Thu, 16 Jan 2020 08:42:17 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CFAECF800E9 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 23:42:14 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,325,1574150400"; d="scan'208";a="220284799" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga008.fm.intel.com with ESMTP; 15 Jan 2020 23:42:13 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 15 Jan 2020 23:42:13 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 16 Jan 2020 15:42:11 +0800 Received: from shsmsx606.ccr.corp.intel.com ([10.109.6.216]) by SHSMSX606.ccr.corp.intel.com ([10.109.6.216]) with mapi id 15.01.1713.004; Thu, 16 Jan 2020 15:42:11 +0800 From: "Liao, Bard" To: Pierre-Louis Bossart , Bard liao , "broonie@kernel.org" , "tiwai@suse.de" Thread-Topic: [alsa-devel] [PATCH RFC v2 4/4] ASoC: add warning if the function is not support multi cpu yet. Thread-Index: AQHVy2dpxOHJKgYqGUCNkHm4lITLIqfsAZYAgADhYqA= Date: Thu, 16 Jan 2020 07:42:11 +0000 Message-ID: <0dbffd0c1b904a1eb57045ff3b5e40b2@intel.com> References: <20200114175152.3291-1-yung-chuan.liao@linux.intel.com> <20200114175152.3291-5-yung-chuan.liao@linux.intel.com> <35fbbfcf-8741-ac4c-56b1-2fd7e19e1a7d@linux.intel.com> In-Reply-To: <35fbbfcf-8741-ac4c-56b1-2fd7e19e1a7d@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.2.0.6 dlp-reaction: no-action dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] MIME-Version: 1.0 Cc: "liam.r.girdwood@linux.intel.com" , "alsa-devel@alsa-project.org" , "kuninori.morimoto.gx@renesas.com" Subject: Re: [alsa-devel] [PATCH RFC v2 4/4] ASoC: add warning if the function is not support multi cpu yet. X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > -----Original Message----- > From: Pierre-Louis Bossart [mailto:pierre-louis.bossart@linux.intel.com] > Sent: Thursday, January 16, 2020 9:50 AM > To: Bard liao ; broonie@kernel.org; > tiwai@suse.de > Cc: liam.r.girdwood@linux.intel.com; alsa-devel@alsa-project.org; Liao, Bard > ; kuninori.morimoto.gx@renesas.com > Subject: Re: [alsa-devel] [PATCH RFC v2 4/4] ASoC: add warning if the function is > not support multi cpu yet. > > > > On 1/14/20 11:51 AM, Bard liao wrote: > > Multi cpu is not supported by all functions yet. Add a warning message > > to warn it. > > Shouldn't we be consistent and return an error when we have an unexpected > number of cpu dais? see below > > > > > Suggested-by: Kuninori Morimoto > > Signed-off-by: Bard liao > > --- > > sound/soc/soc-compress.c | 7 ++++--- > > sound/soc/soc-generic-dmaengine-pcm.c | 12 ++++++++++++ > > sound/soc/soc-pcm.c | 12 ++++++++++++ > > 3 files changed, 28 insertions(+), 3 deletions(-) > > > > diff --git a/sound/soc/soc-compress.c b/sound/soc/soc-compress.c index > > 223cd045719e..bf9d6a21bcd9 100644 > > --- a/sound/soc/soc-compress.c > > +++ b/sound/soc/soc-compress.c > > @@ -810,10 +810,11 @@ int snd_soc_new_compress(struct > snd_soc_pcm_runtime *rtd, int num) > > int playback = 0, capture = 0; > > int i; > > > > - if (rtd->num_codecs > 1) { > > + if (rtd->num_cpus > 1 || > > + rtd->num_codecs) { > > dev_err(rtd->card->dev, > > - "Compress ASoC: Multicodec not supported\n"); > > - return -EINVAL; > > + "Compress ASoC: Multi CPU/Codec not supported\n"); > > + return -ENOTSUPP; > > so this is an error... Changing to -ENOTSUPP will prevent below to return error in soc_init_pcm_runtime(). /* create compress_device if possible */ ret = snd_soc_dai_compress_new(cpu_dai, rtd, num); if (ret != -ENOTSUPP) { if (ret < 0) dev_err(card->dev, "ASoC: can't create compress %s\n", dai_link->stream_name); return ret; } So it is to prevent an error actually. But I agree it is better to return an error when we have an unexpected number of cpu dais. What do you think? @Morimoto-san _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel