From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: pierre-louis.bossart@linux.intel.com,
alsa-devel@alsa-project.org, tiwai@suse.com, hdegoede@redhat.com,
broonie@kernel.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Subject: Re: [PATCH v3 1/4] ALSA: hda: Follow ACPI convention in NHLT struct naming
Date: Fri, 26 Nov 2021 14:48:42 +0100 [thread overview]
Message-ID: <111c2150-cc34-56e1-e4b5-34ccb14c84ce@intel.com> (raw)
In-Reply-To: <s5h5ystvkr4.wl-tiwai@suse.de>
On 2021-11-15 10:19 AM, Takashi Iwai wrote:
> On Wed, 10 Nov 2021 11:31:14 +0100,
> Cezary Rojewski wrote:
>>
>> From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>>
>> All ACPI table structs except for NHLT ones are defined in postfix way.
>> Update NHLT structs naming to make code cohesive.
>>
>> Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>
> This turned out to be conflicting with the definition in
> include/acpi/actbl2.h, which was newly introduced in 5.16-rc1.
>
> So unfortunately I'll have to drop the patches for now.
> Could you rework with 5.16-rc base and resubmit?
Hello,
Sorry for the delay in replying. I've addressed the naming conflicts in
v4 - this patch has been dropped and all the rest updated. Additional
work will be done in separate series to align sound/hda/ with recently
added NHLT-structs in ACPI tree.
Regards,
Czarek
next prev parent reply other threads:[~2021-11-26 13:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 10:31 [PATCH v3 0/4] ALSA: hda: New NHLT functions and cleanup Cezary Rojewski
2021-11-10 10:31 ` [PATCH v3 1/4] ALSA: hda: Follow ACPI convention in NHLT struct naming Cezary Rojewski
2021-11-15 9:19 ` Takashi Iwai
2021-11-26 13:48 ` Cezary Rojewski [this message]
2021-11-10 10:31 ` [PATCH v3 2/4] ALSA: hda: Fill gaps in NHLT endpoint-interface Cezary Rojewski
2021-11-10 10:31 ` [PATCH v3 3/4] ALSA: hda: Simplify DMIC-in-NHLT check Cezary Rojewski
2021-11-10 10:31 ` [PATCH v3 4/4] ASoC: Intel: Skylake: Use NHLT API to search for blob Cezary Rojewski
2021-11-10 14:18 ` Mark Brown
2021-11-14 8:35 ` [PATCH v3 0/4] ALSA: hda: New NHLT functions and cleanup Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=111c2150-cc34-56e1-e4b5-34ccb14c84ce@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).