From: Takashi Iwai <tiwai@suse.de> To: alsa-devel@alsa-project.org Subject: [PATCH 09/24] ALSA: atmel: Convert to snd_card_new() with a device pointer Date: Wed, 12 Feb 2014 11:35:25 +0100 Message-ID: <1392201340-27113-10-git-send-email-tiwai@suse.de> (raw) In-Reply-To: <1392201340-27113-1-git-send-email-tiwai@suse.de> Also remove superfluous snd_card_set_dev() calls. Signed-off-by: Takashi Iwai <tiwai@suse.de> --- sound/atmel/abdac.c | 13 ++++--------- sound/atmel/ac97c.c | 10 +++------- 2 files changed, 7 insertions(+), 16 deletions(-) diff --git a/sound/atmel/abdac.c b/sound/atmel/abdac.c index 3519518e25a0..edf2ca72d518 100644 --- a/sound/atmel/abdac.c +++ b/sound/atmel/abdac.c @@ -429,8 +429,9 @@ static int atmel_abdac_probe(struct platform_device *pdev) } clk_enable(pclk); - retval = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, - THIS_MODULE, sizeof(struct atmel_abdac), &card); + retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, + SNDRV_DEFAULT_STR1, THIS_MODULE, + sizeof(struct atmel_abdac), &card); if (retval) { dev_dbg(&pdev->dev, "could not create sound card device\n"); goto out_put_sample_clk; @@ -467,8 +468,6 @@ static int atmel_abdac_probe(struct platform_device *pdev) goto out_unmap_regs; } - snd_card_set_dev(card, &pdev->dev); - if (pdata->dws.dma_dev) { dma_cap_mask_t mask; @@ -492,7 +491,7 @@ static int atmel_abdac_probe(struct platform_device *pdev) if (!pdata->dws.dma_dev || !dac->dma.chan) { dev_dbg(&pdev->dev, "DMA not available\n"); retval = -ENODEV; - goto out_unset_card_dev; + goto out_unmap_regs; } strcpy(card->driver, "Atmel ABDAC"); @@ -521,9 +520,6 @@ static int atmel_abdac_probe(struct platform_device *pdev) out_release_dma: dma_release_channel(dac->dma.chan); dac->dma.chan = NULL; -out_unset_card_dev: - snd_card_set_dev(card, NULL); - free_irq(irq, dac); out_unmap_regs: iounmap(dac->regs); out_free_card: @@ -579,7 +575,6 @@ static int atmel_abdac_remove(struct platform_device *pdev) dma_release_channel(dac->dma.chan); dac->dma.chan = NULL; - snd_card_set_dev(card, NULL); iounmap(dac->regs); free_irq(dac->irq, dac); snd_card_free(card); diff --git a/sound/atmel/ac97c.c b/sound/atmel/ac97c.c index c5f0ddd729b3..05ec049c9faf 100644 --- a/sound/atmel/ac97c.c +++ b/sound/atmel/ac97c.c @@ -945,8 +945,9 @@ static int atmel_ac97c_probe(struct platform_device *pdev) } clk_enable(pclk); - retval = snd_card_create(SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1, - THIS_MODULE, sizeof(struct atmel_ac97c), &card); + retval = snd_card_new(&pdev->dev, SNDRV_DEFAULT_IDX1, + SNDRV_DEFAULT_STR1, THIS_MODULE, + sizeof(struct atmel_ac97c), &card); if (retval) { dev_dbg(&pdev->dev, "could not create sound card device\n"); goto err_snd_card_new; @@ -990,8 +991,6 @@ static int atmel_ac97c_probe(struct platform_device *pdev) chip->reset_pin = -EINVAL; } - snd_card_set_dev(card, &pdev->dev); - atmel_ac97c_reset(chip); /* Enable overrun interrupt from codec channel */ @@ -1113,8 +1112,6 @@ err_dma: chip->dma.tx_chan = NULL; } err_ac97_bus: - snd_card_set_dev(card, NULL); - if (gpio_is_valid(chip->reset_pin)) gpio_free(chip->reset_pin); @@ -1195,7 +1192,6 @@ static int atmel_ac97c_remove(struct platform_device *pdev) chip->dma.tx_chan = NULL; } - snd_card_set_dev(card, NULL); snd_card_free(card); return 0; -- 1.8.5.2
next prev parent reply index Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-02-12 10:35 [RFC PATCH 00/24] Mandate to pass a device pointer at card creation Takashi Iwai 2014-02-12 10:35 ` [PATCH 01/24] ALSA: Drop unused name argument in snd_register_oss_device() Takashi Iwai 2014-02-12 10:35 ` [PATCH 02/24] ALSA: Mandate to pass a device pointer at card creation time Takashi Iwai 2014-02-12 10:35 ` [PATCH 03/24] ALSA: drivers: Convert to snd_card_new() with a device pointer Takashi Iwai 2014-02-12 10:35 ` [PATCH 04/24] ALSA: isa: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 05/24] ALSA: pci: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 06/24] ALSA: usb: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 07/24] ALSA: firewire: " Takashi Iwai 2014-02-14 6:56 ` Takashi Sakamoto 2014-02-12 10:35 ` [PATCH 08/24] ALSA: arm: " Takashi Iwai 2014-02-12 10:35 ` Takashi Iwai [this message] 2014-02-12 10:35 ` [PATCH 10/24] ALSA: au1x00: convert to platform device Takashi Iwai 2014-02-14 0:19 ` Michał Mirosław 2014-02-14 7:33 ` Takashi Iwai 2014-02-12 10:35 ` [PATCH 11/24] ALSA: mips: Convert to snd_card_new() with a device pointer Takashi Iwai 2014-02-12 10:35 ` [PATCH 12/24] ALSA: parisc: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 13/24] ALSA: pcmcia: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 14/24] ALSA: ppc: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 15/24] ALSA: sh: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 16/24] ALSA: sparc: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 17/24] ALSA: spi: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 18/24] ASoC: core: " Takashi Iwai 2014-02-12 13:04 ` Mark Brown 2014-02-12 13:10 ` Takashi Iwai 2014-02-12 10:35 ` [PATCH 19/24] HID: prodikeys: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 20/24] [media] " Takashi Iwai 2014-02-12 10:35 ` [PATCH 21/24] thinkpad_acpi: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 22/24] staging/line6: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 23/24] staging/media: " Takashi Iwai 2014-02-12 10:35 ` [PATCH 24/24] usb: gadget: " Takashi Iwai 2014-02-14 11:58 ` [RFC PATCH 00/24] Mandate to pass a device pointer at card creation Takashi Iwai
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1392201340-27113-10-git-send-email-tiwai@suse.de \ --to=tiwai@suse.de \ --cc=alsa-devel@alsa-project.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Alsa-Devel Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \ alsa-devel@alsa-project.org public-inbox-index alsa-devel Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git