From: Julia Lawall <Julia.Lawall@lip6.fr>
To: Jaroslav Kysela <perex@perex.cz>
Cc: kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: [PATCH 6/9] sound/pci/ctxfi/ctatc.c: fix error return code
Date: Sun, 23 Nov 2014 13:48:06 +0100 [thread overview]
Message-ID: <1416746890-22719-6-git-send-email-Julia.Lawall@lip6.fr> (raw)
In-Reply-To: <1416746890-22719-1-git-send-email-Julia.Lawall@lip6.fr>
From: Julia Lawall <Julia.Lawall@lip6.fr>
Initialize err before returning on failure, as done elsewhere in the
function.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
sound/pci/ctxfi/ctatc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/pci/ctxfi/ctatc.c b/sound/pci/ctxfi/ctatc.c
index 58b235c..a2f997a 100644
--- a/sound/pci/ctxfi/ctatc.c
+++ b/sound/pci/ctxfi/ctatc.c
@@ -1725,8 +1725,10 @@ int __devinit ct_atc_create(struct snd_card *card, struct pci_dev *pci,
atc_connect_resources(atc);
atc->timer = ct_timer_new(atc);
- if (!atc->timer)
+ if (!atc->timer) {
+ err = -ENOMEM;
goto error1;
+ }
err = snd_device_new(card, SNDRV_DEV_LOWLEVEL, atc, &ops);
if (err < 0)
next prev parent reply other threads:[~2014-11-23 12:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-23 12:48 [PATCH 0/10] fix error return code Julia Lawall
2014-11-23 12:48 ` [PATCH 2/10] sound/soc/fsl/imx-sgtl5000.c: " Julia Lawall
2014-11-23 12:48 ` [PATCH 1/10] sound/soc/ux500/ux500_msp_i2s.c: better use devm functions and " Julia Lawall
2014-11-23 12:48 ` [PATCH 8/9] sound/pci/rme9652/hdspm.c: " Julia Lawall
2014-11-23 12:48 ` [PATCH 7/9] sound/pci/sis7019.c: " Julia Lawall
2014-11-23 12:48 ` Julia Lawall [this message]
2014-11-23 17:15 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Sudip Mukherjee
2014-11-23 19:11 ` Julia Lawall
2014-11-23 12:48 ` [PATCH 5/9] sound/atmel/ac97c.c: " Julia Lawall
2014-11-23 12:48 ` [PATCH 3/10] sound/atmel/abdac.c: " Julia Lawall
2014-11-23 12:48 ` [PATCH 9/9] sound/ppc/snd_ps3.c: " Julia Lawall
2014-11-23 12:48 ` [PATCH 4/9] sound/soc/omap/am3517evm.c: " Julia Lawall
2014-11-23 13:15 ` [PATCH 0/10] " Julia Lawall
-- strict thread matches above, loose matches on Subject: below --
2015-04-05 11:38 Julia Lawall
2015-04-05 11:38 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Julia Lawall
2015-04-05 12:13 ` Julia Lawall
2012-08-19 7:02 [PATCH 0/10] " Julia Lawall
2012-08-19 7:02 ` [PATCH 6/9] sound/pci/ctxfi/ctatc.c: " Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416746890-22719-6-git-send-email-Julia.Lawall@lip6.fr \
--to=julia.lawall@lip6.fr \
--cc=alsa-devel@alsa-project.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).