From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B544C33CB2 for ; Wed, 15 Jan 2020 15:08:19 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 161672187F for ; Wed, 15 Jan 2020 15:08:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="YUybQKS0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 161672187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4C45817A1; Wed, 15 Jan 2020 16:07:27 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4C45817A1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579100897; bh=ODzR4l3tpJ5efAVoqjYyZ4AT3DoRSe2QRrra6ktTJNA=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YUybQKS025IxWWzXS0MCvL2z9+A0poGPppuT5X1IhF1hTZePCCEdzlaFhI+wm/nrU iQDYiFEKFkrahfffDXJtRTjRPs4TqpwkdPSoGpHXE7xbBOJSYAqgwOCJXSQb05exll AzUx27cmRfYOT2TnB23mpQAv2qY0kJ98UJvXUhDY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B61C6F8014B; Wed, 15 Jan 2020 16:07:26 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id BF436F801EB; Wed, 15 Jan 2020 16:07:24 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4FBA5F800CC for ; Wed, 15 Jan 2020 16:07:18 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4FBA5F800CC X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Jan 2020 07:07:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,322,1574150400"; d="diff'?scan'208";a="256802220" Received: from sbreyer-mobl.amr.corp.intel.com (HELO [10.255.228.18]) ([10.255.228.18]) by fmsmga002.fm.intel.com with ESMTP; 15 Jan 2020 07:07:15 -0800 To: ojab // References: <87h80x8t41.wl-kuninori.morimoto.gx@renesas.com> <130af222-1086-ebcf-6a0f-9a390f9afbc3@linux.intel.com> From: Pierre-Louis Bossart Message-ID: <14259e97-72f5-439f-b2f1-356b6e45bcfb@linux.intel.com> Date: Wed, 15 Jan 2020 09:07:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------97225A65C771DFF3C8326034" Content-Language: en-US Cc: alsa-devel@alsa-project.org, Ranjani Sridharan , Kuninori Morimoto Subject: Re: [alsa-devel] No sound since 5.4 on skl_n88l25_s4567 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" This is a multi-part message in MIME format. --------------97225A65C771DFF3C8326034 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 1/15/20 5:57 AM, ojab // wrote: > On Wed, Jan 15, 2020 at 4:41 AM Pierre-Louis Bossart > wrote: >> Please post the results of alsa-info.sh somewhere so that we can take a >> look. Thanks, I think that confirms my theory. > 5.3.0: http://alsa-project.org/db/?f=d82b3ef237a5050dfb73231ba114e45a6a4420ef In this case, there's a warning on the routes: [ 22.364318] skl_n88l25_s4567 skl_n88l25_s4567: ASoC: Failed to add route iDisp3_out -> direct -> iDisp3 Tx > 5.4.0: http://alsa-project.org/db/?f=d922b77306a1287eae3624d241f3d46d347c8098 And we know that in 5.4 errors on routes caused the card registration to stop. I *think* the patch was daa480bde6b3a9 ("ASoC: soc-core: tidyup for snd_soc_dapm_add_routes()") This patch won't revert cleanly, can you try the following hack on v5.4 to see if this improves the card registration? Thanks! --------------97225A65C771DFF3C8326034 Content-Type: text/x-patch; charset=UTF-8; name="routes.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="routes.diff" diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 88978a3036c4..796d14feab4d 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -1076,8 +1076,8 @@ static int soc_probe_component(struct snd_soc_card *card, ret = snd_soc_dapm_add_routes(dapm, component->driver->dapm_routes, component->driver->num_dapm_routes); - if (ret < 0) - goto err_probe; + //if (ret < 0) + // goto err_probe; /* see for_each_card_components */ list_add(&component->card_list, &card->component_dev_list); @@ -2065,13 +2065,13 @@ static int snd_soc_instantiate_card(struct snd_soc_card *card) ret = snd_soc_dapm_add_routes(&card->dapm, card->dapm_routes, card->num_dapm_routes); - if (ret < 0) - goto probe_end; + //if (ret < 0) + // goto probe_end; ret = snd_soc_dapm_add_routes(&card->dapm, card->of_dapm_routes, - card->num_of_dapm_routes); - if (ret < 0) - goto probe_end; + card->num_of_dapm_routes); + //if (ret < 0) + // goto probe_end; /* try to set some sane longname if DMI is available */ snd_soc_set_dmi_name(card, NULL); --------------97225A65C771DFF3C8326034 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel --------------97225A65C771DFF3C8326034--