From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFDEBC433DF for ; Thu, 30 Jul 2020 22:36:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A4A920838 for ; Thu, 30 Jul 2020 22:36:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="DXYfyWTX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f+fyTg5m" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A4A920838 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 94B0616A6; Fri, 31 Jul 2020 00:35:10 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 94B0616A6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1596148560; bh=CO37PAhunBqjgO0OJf6XyiHTMf9GToTDYH/qSHwYFwk=; h=Date:From:To:In-Reply-To:References:Subject:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=DXYfyWTX3diYOLwejfm0jW2jWEsaVmbNsPaj0MBysd2bfLpTi48qvLyrlF55ScVba dqsexO0/z+vVEPMSm/0e1UPEOiYErrkvGOb+2PqEFfGxISUDsGuDtPa5L96Gcb256a qvTmhBrYY9kce7+ylehIjkGTopCO+Q98OPOPdFzo= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0085EF80316; Fri, 31 Jul 2020 00:30:01 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 7F898F80307; Fri, 31 Jul 2020 00:28:54 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A821DF80303 for ; Fri, 31 Jul 2020 00:28:51 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A821DF80303 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="f+fyTg5m" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61D9E20838; Thu, 30 Jul 2020 22:28:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596148130; bh=CO37PAhunBqjgO0OJf6XyiHTMf9GToTDYH/qSHwYFwk=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=f+fyTg5mDxWEz242p14lrlNUDh5OdVbXRxadG2fVuX69OwiIlrntWdEga9eomeFKZ YkW5DVQiXbrWi+ZnY8ILqSepkXV8gFetevnFm3K3sMfjbEG4/QOxCmZLsH1zJxGZgG hqh4/QGoQzjoct8E6TD0QjUXC5K0Srk84lFRZx/s= Date: Thu, 30 Jul 2020 23:28:29 +0100 From: Mark Brown To: Charles Keepax In-Reply-To: <20200730120715.637-1-ckeepax@opensource.cirrus.com> References: <20200730120715.637-1-ckeepax@opensource.cirrus.com> Subject: Re: [PATCH] ASoC: soc-core: Fix regression causing sysfs entries to disappear Message-Id: <159614804535.1473.17195718033105583063.b4-ty@kernel.org> Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, lgirdwood@gmail.com, kuninori.morimoto.gx@renesas.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 30 Jul 2020 13:07:14 +0100, Charles Keepax wrote: > The allocation order of things in soc_new_pcm_runtime was changed to > move the device_register before the allocation of the rtd structure. > This was to allow the rtd allocation to be managed by devm. However > currently the sysfs entries are added by device_register and their > visibility depends on variables within the rtd structure, this causes > the pmdown_time and dapm_widgets sysfs entries to be missing for all > rtds. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: soc-core: Fix regression causing sysfs entries to disappear commit: 5c74c9d34aec1ac756de6979dd5580096aba8643 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark