Alsa-Devel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] ASoC: SOF: imx: use resource_size
@ 2020-07-26  8:25 Julia Lawall
  2020-07-30 22:27 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Julia Lawall @ 2020-07-26  8:25 UTC (permalink / raw)
  To: Pierre-Louis Bossart
  Cc: alsa-devel, Fabio Estevam, linux-kernel, Kai Vehmanen, Shawn Guo,
	Sascha Hauer, Takashi Iwai, kernel-janitors, Liam Girdwood,
	Ranjani Sridharan, Mark Brown, NXP Linux Team,
	Pengutronix Kernel Team, Daniel Baluta, linux-arm-kernel,
	sound-open-firmware

Use resource_size rather than a verbose computation on
the end and start fields.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

<smpl>
@@ struct resource ptr; @@
- (ptr.end - ptr.start + 1)
+ resource_size(&ptr)
</smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 sound/soc/sof/imx/imx8m.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff -u -p a/sound/soc/sof/imx/imx8m.c b/sound/soc/sof/imx/imx8m.c
--- a/sound/soc/sof/imx/imx8m.c
+++ b/sound/soc/sof/imx/imx8m.c
@@ -188,8 +188,7 @@ static int imx8m_probe(struct snd_sof_de
 	}
 
 	sdev->bar[SOF_FW_BLK_TYPE_SRAM] = devm_ioremap_wc(sdev->dev, res.start,
-							  res.end - res.start +
-							  1);
+							  resource_size(&res));
 	if (!sdev->bar[SOF_FW_BLK_TYPE_SRAM]) {
 		dev_err(sdev->dev, "failed to ioremap mem 0x%x size 0x%x\n",
 			base, size);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: SOF: imx: use resource_size
  2020-07-26  8:25 [PATCH] ASoC: SOF: imx: use resource_size Julia Lawall
@ 2020-07-30 22:27 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2020-07-30 22:27 UTC (permalink / raw)
  To: Julia Lawall, Pierre-Louis Bossart
  Cc: alsa-devel, Fabio Estevam, Kai Vehmanen, Liam Girdwood,
	Shawn Guo, Sascha Hauer, kernel-janitors, linux-kernel,
	Takashi Iwai, Ranjani Sridharan, Pengutronix Kernel Team,
	NXP Linux Team, Daniel Baluta, linux-arm-kernel,
	sound-open-firmware

On Sun, 26 Jul 2020 10:25:33 +0200, Julia Lawall wrote:
> Use resource_size rather than a verbose computation on
> the end and start fields.
> 
> The semantic patch that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
> 
> <smpl>
> @@ struct resource ptr; @@
> - (ptr.end - ptr.start + 1)
> + resource_size(&ptr)
> </smpl>

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: imx: use resource_size
      commit: afd842c031408f9eaf689ff417071eed15afa05e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-26  8:25 [PATCH] ASoC: SOF: imx: use resource_size Julia Lawall
2020-07-30 22:27 ` Mark Brown

Alsa-Devel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/alsa-devel/0 alsa-devel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 alsa-devel alsa-devel/ https://lore.kernel.org/alsa-devel \
		alsa-devel@alsa-project.org
	public-inbox-index alsa-devel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.alsa-project.alsa-devel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git