From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Mark Brown <broonie@kernel.org>, <tzungbi@google.com>
Cc: alsa-devel@alsa-project.org, shane.chien@mediatek.com,
howie.huang@mediatek.com, tiwai@suse.com,
linux-kernel@vger.kernel.org, tzungbi@google.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
eason.yen@mediatek.com, matthias.bgg@gmail.com,
Bicycle.Tsai@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver
Date: Sun, 16 Aug 2020 01:27:01 +0800 [thread overview]
Message-ID: <1597512421.23246.74.camel@mhfsdcap03> (raw)
In-Reply-To: <20200814160115.GC4783@sirena.org.uk>
On Fri, 2020-08-14 at 17:01 +0100, Mark Brown wrote:
> On Fri, Aug 14, 2020 at 06:45:53PM +0800, Jiaxin Yu wrote:
>
> This looks mostly good, a couple of very small things:
>
> > + ret = regulator_enable(priv->avdd_reg);
> > + if (ret) {
> > + dev_err(&pdev->dev, "%s(), failed to enable regulator!\n",
> > + __func__);
> > + return ret;
> > + }
>
> You need a remove() function to undo this enable.
>
Ok, I will add a remove() function to do regulator_disable() and
snd_soc_unregister_component().
> > + dev_info(&pdev->dev, "%s(), dev name %s\n",
> > + __func__, dev_name(&pdev->dev));
>
> This isn't really adding anything, just remove it - it's not reading
> info from the hardware or anything.
Yes, it was unnecessary, removed it in PATCH v4.
next prev parent reply other threads:[~2020-08-15 18:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 10:45 [PATCH v3 0/2] Add mediatek codec mt6359 driver Jiaxin Yu
2020-08-14 10:45 ` [PATCH v3 1/2] WIP: ASoC: mediatek: mt6359: add codec driver Jiaxin Yu
2020-08-14 16:01 ` Mark Brown
2020-08-15 17:27 ` Jiaxin Yu [this message]
2020-08-14 10:45 ` [PATCH v3 2/2] WIP: dt-bindings: mediatek: mt6359: add codec document Jiaxin Yu
2020-08-14 13:18 ` [PATCH v3 0/2] Add mediatek codec mt6359 driver Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597512421.23246.74.camel@mhfsdcap03 \
--to=jiaxin.yu@mediatek.com \
--cc=Bicycle.Tsai@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=eason.yen@mediatek.com \
--cc=howie.huang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).