From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23BA3C433E3 for ; Tue, 18 Aug 2020 17:01:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A397C2067C for ; Tue, 18 Aug 2020 17:01:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="At+9VC/O"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bHQOeTXi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A397C2067C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2AFD717B3; Tue, 18 Aug 2020 19:00:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2AFD717B3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1597770071; bh=jKm2t81NtYjV40fRviXCJZukNmdxkXqUVLGa7N1IAnM=; h=Date:From:To:In-Reply-To:References:Subject:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=At+9VC/Ood6RhoE9TZ8H5CAHhOMFUglnBEcayfjICYSbz+b+26d9LtPIWNALvBDJL 6ib9vBe9xdHtgyWdmuqolYRFKU02t5/vpadCLj3qL+OPnyODdUhBgO7rVe7tldjyde hdj3Ypq5B8c7C75ivLvWwt4tIC9myJVUU1JplwK8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id EB656F80328; Tue, 18 Aug 2020 18:55:05 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 780E0F80332; Tue, 18 Aug 2020 18:55:04 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4B811F80328 for ; Tue, 18 Aug 2020 18:55:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4B811F80328 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="bHQOeTXi" Received: from localhost (fw-tnat.cambridge.arm.com [217.140.96.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 700B5207DA; Tue, 18 Aug 2020 16:55:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597769701; bh=jKm2t81NtYjV40fRviXCJZukNmdxkXqUVLGa7N1IAnM=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=bHQOeTXib9+XN32Hhfn7nLtuMO3JpGzdl/Q5SxvbeXE627jk6OBNcSszTdCEGnVEj MqlZ/gkWly6tf5+Ro715BYsnt5sphihRvsMnBt2ncDpL+J5PFCmBOt+bv1Jrq4GvHr hKQ39ZsBjXJCt5MbN5Q4njHaNUYYYgqxbJ+8B0os= Date: Tue, 18 Aug 2020 17:54:30 +0100 From: Mark Brown To: Dinghao Liu , kjlu@umn.edu In-Reply-To: <20200813084112.26205-1-dinghao.liu@zju.edu.cn> References: <20200813084112.26205-1-dinghao.liu@zju.edu.cn> Subject: Re: [PATCH] [v2] ASoC: intel: Fix memleak in sst_media_open Message-Id: <159776961932.56094.14732357136908133614.b4-ty@kernel.org> Cc: Cezary Rojewski , Kuninori Morimoto , linux-kernel@vger.kernel.org, Takashi Iwai , Jie Yang , Pierre-Louis Bossart , Liam Girdwood , Vinod Koul , Ranjani Sridharan , alsa-devel@alsa-project.org, "Subhransu S. Prusty" X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Thu, 13 Aug 2020 16:41:10 +0800, Dinghao Liu wrote: > When power_up_sst() fails, stream needs to be freed > just like when try_module_get() fails. However, current > code is returning directly and ends up leaking memory. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: intel: Fix memleak in sst_media_open commit: 062fa09f44f4fb3776a23184d5d296b0c8872eb9 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark