From: Jiaxin Yu <jiaxin.yu@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
shane.chien@mediatek.com, tiwai@suse.com, tzungbi@google.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] ASoC: mt6359: skip first time data at the beginning of DMIC recording
Date: Tue, 27 Oct 2020 18:28:58 +0800 [thread overview]
Message-ID: <1603794538.26523.6.camel@mhfsdcap03> (raw)
In-Reply-To: <20201026123325.GC7402@sirena.org.uk>
On Mon, 2020-10-26 at 12:33 +0000, Mark Brown wrote:
> On Sat, Oct 24, 2020 at 02:41:25PM +0800, Jiaxin Yu wrote:
> > We can choose to drop away any length of data from the beginning according
> > to project needs. Some projects don't want to throw away any data, because
> > they want to use recorded data to do echo cancellation, so they have to
> > make sure that they are aligned with the reference data as much as
> > possible. Or there are other algorithms in the upper layer to eliminate
> > this noise. Or some projects want to eliminate this noise form the kernel
> > layer. However, the minimum recommended value is 50ms to skip pop noise.
>
> This seems like something that would apply equally to all DMICs so
> should be done at a more general level rather than in this specific
> driver, for example it could be done in the DMIC driver.
Hi Brown,
So you suggest that we use sound/soc/codecs/dmic.c to control the delay
after recording?
If so, should we add one more CODEC('dmic-codec' and 'dmic-hifi') to
dmic's dai-link? It looks link dmic.c has helped us do something to
control dmics.
next prev parent reply other threads:[~2020-10-27 10:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 6:41 [PATCH 0/2] ASoC: mt6359: skip first time data at the beginning of DMIC recording Jiaxin Yu
2020-10-24 6:41 ` [PATCH 1/2] " Jiaxin Yu
2020-10-26 12:33 ` Mark Brown
2020-10-27 10:28 ` Jiaxin Yu [this message]
2020-10-27 13:15 ` Mark Brown
2020-10-28 9:39 ` Jiaxin Yu
2020-10-24 6:41 ` [PATCH 2/2] dt-bindings: mediatek: mt8192: add ul-delay-ms property Jiaxin Yu
2020-10-30 18:23 ` Rob Herring
2020-10-31 11:38 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1603794538.26523.6.camel@mhfsdcap03 \
--to=jiaxin.yu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=tiwai@suse.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).