From: Richard Fitzgerald via Alsa-devel <alsa-devel@alsa-project.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, <broonie@kernel.org>
Cc: tiwai@suse.com, alsa-devel@alsa-project.org,
patches@opensource.cirrus.com, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative
Date: Fri, 24 Mar 2023 10:29:15 +0000 [thread overview]
Message-ID: <167965379262.26.7264259412177120137@mailman-core.alsa-project.org> (raw)
In-Reply-To: <20230324022303.121485-1-jiapeng.chong@linux.alibaba.com>
[-- Attachment #0: Type: message/rfc822, Size: 6060 bytes --]
From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, <broonie@kernel.org>
Cc: tiwai@suse.com, alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative
Date: Fri, 24 Mar 2023 10:29:15 +0000
Message-ID: <ceac5217-2fae-7d56-341f-6527ef3f538e@opensource.cirrus.com>
On 24/03/2023 02:23, Jiapeng Chong wrote:
> The variable 'rv' is defined as unsigned type, so the following if
> statement is invalid, we can modify the type of rv to int.
> if (rv < 0) {
> dev_err(cs35l56->dev, "irq: failed to get pm_runtime:
> %d\n", rv);
> goto err_unlock;
> }
>
> ./sound/soc/codecs/cs35l56.c:333:5-7: WARNING: Unsigned expression compared with zero: rv < 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4599
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> sound/soc/codecs/cs35l56.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/cs35l56.c b/sound/soc/codecs/cs35l56.c
> index 90fc79b5666d..d97b465f0d3c 100644
> --- a/sound/soc/codecs/cs35l56.c
> +++ b/sound/soc/codecs/cs35l56.c
> @@ -321,7 +321,9 @@ irqreturn_t cs35l56_irq(int irq, void *data)
> struct cs35l56_private *cs35l56 = data;
> unsigned int status1 = 0, status8 = 0, status20 = 0;
> unsigned int mask1, mask8, mask20;
> - unsigned int rv, val;
> + unsigned int val;
> + int rv;
> +
> irqreturn_t ret = IRQ_NONE;
>
> if (!cs35l56->init_done)
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
next prev parent reply other threads:[~2023-03-24 10:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 2:23 [PATCH] ASoC: cs35l56: Fix an unsigned comparison which can never be negative Jiapeng Chong
2023-03-24 10:29 ` Richard Fitzgerald via Alsa-devel [this message]
2023-03-24 14:19 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167965379262.26.7264259412177120137@mailman-core.alsa-project.org \
--to=alsa-devel@alsa-project.org \
--cc=abaci@linux.alibaba.com \
--cc=broonie@kernel.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).