From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Cezary Rojewski <cezary.rojewski@intel.com>, alsa-devel@alsa-project.org
Cc: lars@metafoo.de, olivier.moysan@st.com, alexandre.torgue@st.com,
lgirdwood@gmail.com, arnaud.pouliquen@st.com, tiwai@suse.com,
broonie@kernel.org, mcoquelin.stm32@gmail.com
Subject: Re: [PATCH 0/3] ASoC: core: Two step component registration
Date: Fri, 31 Jul 2020 10:07:23 -0500 [thread overview]
Message-ID: <1828f3a2-f198-e6cd-ca6c-c66dc1ef82d1@linux.intel.com> (raw)
In-Reply-To: <20200731144146.6678-1-cezary.rojewski@intel.com>
On 7/31/20 9:41 AM, Cezary Rojewski wrote:
> Provide a mechanism for true two-step component registration. This
> mimics device registration flow where initialization is the first step
> while addition goes as second in line. Drivers may choose to modify
> component's fields before registering component to ASoC subsystem via
> snd_soc_add_component.
I must admit I don't see where this might be used for Intel platforms,
we've been happily using snd_soc_register_component() without hitting
limitations.
Also the only two uses of snd_soc_add_component() seem mainly driven by
memory allocation - and avoiding a devm_kzalloc in
snd_soc_register_component().
Out of curiosity, can you provide an example where this two-step would
be required or beneficial? Thanks!
> Patchset achieves status quo - behavior of snd_soc_register_component
> remains unchanged.
>
> Cezary Rojewski (3):
> ASoC: core: Relocate and expose snd_soc_component_initialize
> ASoC: core: Simplify snd_soc_component_initialize declaration
> ASoC: core: Two step component registration
>
> include/sound/soc-component.h | 3 --
> include/sound/soc.h | 11 +++---
> sound/soc/soc-component.c | 16 ---------
> sound/soc/soc-core.c | 52 +++++++++++++++++----------
> sound/soc/soc-generic-dmaengine-pcm.c | 14 +++++---
> sound/soc/stm/stm32_adfsdm.c | 9 +++--
> 6 files changed, 55 insertions(+), 50 deletions(-)
>
next prev parent reply other threads:[~2020-07-31 15:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-31 14:41 [PATCH 0/3] ASoC: core: Two step component registration Cezary Rojewski
2020-07-31 14:41 ` [PATCH 1/3] ASoC: core: Relocate and expose snd_soc_component_initialize Cezary Rojewski
2020-07-31 14:41 ` [PATCH 2/3] ASoC: core: Simplify snd_soc_component_initialize declaration Cezary Rojewski
2020-07-31 14:41 ` [PATCH 3/3] ASoC: core: Two step component registration Cezary Rojewski
2020-07-31 15:07 ` Pierre-Louis Bossart [this message]
2020-07-31 15:47 ` [PATCH 0/3] " Cezary Rojewski
2020-07-31 15:58 ` Lars-Peter Clausen
2020-07-31 16:09 ` Cezary Rojewski
2020-07-31 16:42 ` Mark Brown
2020-07-31 18:54 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1828f3a2-f198-e6cd-ca6c-c66dc1ef82d1@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alexandre.torgue@st.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnaud.pouliquen@st.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=olivier.moysan@st.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).