From: "Trevor Wu (吳文良)" <Trevor.Wu@mediatek.com>
To: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"broonie@kernel.org" <broonie@kernel.org>,
"tiwai@suse.com" <tiwai@suse.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver
Date: Sat, 15 Oct 2022 02:27:20 +0000 [thread overview]
Message-ID: <1f7176b1873088cedb975e96bc16c089d80f16c7.camel@mediatek.com> (raw)
In-Reply-To: <3c29ee7116597caf5469bab813ece3bb45723b84.camel@mediatek.com>
On Thu, 2022-10-06 at 10:48 +0800, Trevor Wu wrote:
> On Tue, 2022-10-04 at 11:36 +0200, AngeloGioacchino Del Regno wrote:
..snip
>
> > >
> > > +#include "mt8188-afe-common.h"
> > > +#include "mt8188-afe-clk.h"
> > > +#include "mt8188-reg.h"
> > > +#include "../common/mtk-afe-platform-driver.h"
> > > +#include "../common/mtk-afe-fe-dai.h"
> > > +
> > > +#define MTK_SIP_AUDIO_CONTROL MTK_SIP_SMC_CMD(0x517)
> >
> > This definition goes to include/linux/soc/mediatek/mtk_sip_svc.h
> >
>
> Hi Angelo,
>
> If I move the definition to
> "include/linux/soc/mediatek/mtk_sip_svc.h",
> I should submit it to another tree.
> In the case, do you have any suggestion to handle the dependent
> problem?
>
> > > +
> > >
Hi Angelo,
I found ohter MTK drivers[1][2] also put the definition under module
driver insted of mtk_sip_svc.h.
I still prefer to put the definition under sound/soc/mediatek in case
of dependency problem, but I will move it to
sound/soc/mediatek/common/mtk-afe-base.h in v2 becasue this is common
for MTK sound driver.
Thanks,
Trevor
[1]
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/gpu/drm/mediatek/mtk_dp.c?h=next-20221014#n37
[2]
https://elixir.bootlin.com/linux/latest/source/drivers/ufs/host/ufs-mediatek.h#L83
next prev parent reply other threads:[~2022-10-15 2:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 14:56 [PATCH 00/12] ASoC: mediatek: Add support for MT8188 SoC Trevor Wu
2022-09-30 14:56 ` [PATCH 01/12] ASoC: mediatek: common: add SMC ops ID Trevor Wu
2022-09-30 14:56 ` [PATCH 02/12] ASoC: mediatek: mt8188: add common header Trevor Wu
2022-09-30 14:56 ` [PATCH 03/12] ASoC: mediatek: mt8188: support audsys clock Trevor Wu
2022-09-30 14:56 ` [PATCH 04/12] ASoC: mediatek: mt8188: support adda in platform driver Trevor Wu
2022-10-04 9:37 ` AngeloGioacchino Del Regno
2022-10-05 7:14 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 05/12] ASoC: mediatek: mt8188: support etdm " Trevor Wu
2022-09-30 14:56 ` [PATCH 06/12] ASoC: mediatek: mt8188: support pcmif " Trevor Wu
2022-09-30 14:56 ` [PATCH 07/12] ASoC: mediatek: mt8188: support audio clock control Trevor Wu
2022-09-30 14:56 ` [PATCH 08/12] ASoC: mediatek: mt8188: add platform driver Trevor Wu
2022-10-04 9:36 ` AngeloGioacchino Del Regno
2022-10-06 2:48 ` Trevor Wu (吳文良)
2022-10-15 2:27 ` Trevor Wu (吳文良) [this message]
[not found] ` <202210011740.ZdLtxKq1-lkp@intel.com>
2022-10-05 6:50 ` Trevor Wu (吳文良)
2022-10-05 10:59 ` Mark Brown
2022-10-06 3:13 ` Trevor Wu (吳文良)
2022-09-30 14:56 ` [PATCH 09/12] ASoC: mediatek: mt8188: add control for timing select Trevor Wu
2022-09-30 14:56 ` [PATCH 10/12] dt-bindings: mediatek: mt8188: add audio afe document Trevor Wu
2022-09-30 22:05 ` Rob Herring
2022-10-05 3:57 ` Trevor Wu (吳文良)
2022-10-28 23:46 ` Krzysztof Kozlowski
2022-10-03 16:30 ` Rob Herring
2022-10-05 10:12 ` Trevor Wu (吳文良)
2022-09-30 14:57 ` [PATCH 11/12] ASoC: mediatek: mt8188: add machine driver with mt6359 Trevor Wu
2022-09-30 14:57 ` [PATCH 12/12] dt-bindings: mediatek: mt8188: add mt8188-mt6359 document Trevor Wu
2022-10-03 16:38 ` Rob Herring
2022-10-06 2:38 ` Trevor Wu (吳文良)
2022-10-21 8:54 ` Trevor Wu (吳文良)
2022-10-21 8:58 ` Trevor Wu (吳文良)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7176b1873088cedb975e96bc16c089d80f16c7.camel@mediatek.com \
--to=trevor.wu@mediatek.com \
--cc=alsa-devel@alsa-project.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).